Closed Bug 1696555 Opened 4 years ago Closed 4 years ago

make more text from the tab label in the active tab visible

Categories

(Toolkit :: Themes, defect)

defect

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox88 --- fixed
firefox89 --- verified

People

(Reporter: soeren.hentzschel, Assigned: ntim)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted, Whiteboard: [proton-tabs-bar])

Attachments

(3 files)

Attached image screenshot (deleted) —

(I was asked on chat.mozilla.org to file this as a Bugzilla issue.)

With the Proton tabs enabled and many open tabs you can't see even one single character in the active tab. I attached a screenshot to show the issue.

Mentor: ntim.bugs
Whiteboard: [proton-tabs-bar]

This can be fixed by reducing the 8px value at: https://searchfox.org/mozilla-central/rev/eeb8cf278192d68b3977d0adb4d43f1463439269/browser/themes/shared/tabs.inc.css#478

As long as no text overlaps the tab close button hover effect, it should be good :)

Assignee: nobody → ntim.bugs
Mentor: ntim.bugs
Keywords: good-first-bug
Attachment #9207508 - Attachment description: Bug 1696555 - Remove spacing before tab close button. r=jaws → Bug 1696555 - Remove spacing before proton tab close button. r=jaws
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b6147ef8b813 Remove spacing before proton tab close button. r=jaws
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Blocks: 1695140
Attached image Screenshot 2021-03-29 at 16.17.46.png (deleted) —

When having many tabs opened from the focused tab there is around 2-4 litters visible, and for the unfocused tabs there is around 5-6 litters visible.
Are these results are the expected ones?
Thanks.

PS: NI? :ntim is not possible.

Flags: needinfo?(jaws)

Yes, this is the expected result. We cannot show as many letters since we need space for the close button, especially when the tab is hovered.

Flags: needinfo?(jaws)

Verified as fixed on Nightly 89.0a1 on Windows 10 x64, macOS 10.15, Windows 7 x64 and on Ubuntu 20.04 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: