Closed Bug 1695140 Opened 4 years ago Closed 4 years ago

[Proton] Tabs have too much padding and show less of the label, which is especially apparent at their minimum width

Categories

(Firefox :: Tabbed Browser, defect, P2)

Firefox 88
defect
Points:
3

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 --- disabled
firefox89 --- verified
firefox90 --- verified

People

(Reporter: grayshade, Assigned: jaws)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Keywords: regression, Whiteboard: [proton-tabs-bar])

Attachments

(5 files)

Attached image tabs.png (deleted) —

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

Enable proton, browse the web for a bit, look at the tab bar

Actual results:

I can read the first two to three letters of the tab titles. The tab titles are now useless.

Expected results:

The tabs should clearly identify the loaded page.

Component: Untriaged → Tabbed Browser
Whiteboard: [proton-tabs-bar]

Confirmed on macOS. This is true for any tab with a favicon - which would be the majority. Without favicon I see around 8-9 characters. Maybe the min-width needs to be increased with the new tab design.

Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Unspecified → All
Hardware: Unspecified → All
Severity: -- → S2
Keywords: regression
Priority: -- → P2
Summary: [Proton] Tab titles are unreadable → [Proton] Tabs have too much padding and show less of the label, which is especially apparent at their minimum width

The internal padding of the tabs were adjusted in https://bugzilla.mozilla.org/show_bug.cgi?id=1696202.

Laurențiu, can you please retest with tomorrow's Nightly build?

Flags: needinfo?(grayshade)

@jaws I'm not sure that's much better. I guess an extra letter fits in, but they're still faded out from the second letter onwards. And only half a letter is visible in the selected tab title. Tested on 20210304215542.

Flags: needinfo?(grayshade)
Attached image tabs_compact.png (deleted) —
Attached image tabs_normal.png (deleted) —

We were just reviewing now with Aaron and agreed that current nightly state is still not right. Can you please clarify if you need more details from Aaron to help resolve this one or maybe something is in progress that has not yet landed?

Flags: needinfo?(jaws)

Can you please check again in a build that includes https://bugzilla.mozilla.org/show_bug.cgi?id=1696555 ?

Flags: needinfo?(jaws) → needinfo?(rtestard)
Points: --- → 3
Attached image Sans titre.png (deleted) —

At min tab width (tab overscroll enabled), when comparing with current release Firefox on light theme what I notice is:

  • Active tab visible label with favicon is still less visible than by about half a character (this is 20% info lost when we compare 2 to 2.5 characters)
  • Non active tab visible label with favison seems stricly similar to current

Is there still room for adjusting fading on active tabs so visibility on active tab does not regress?

Flags: needinfo?(rtestard)
Depends on: 1696202, 1696555
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8e52988f624b Allow the selected tabs text to extend into the start side of the close buttons padding when its not hovered to show more text. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Regressions: 1701065
Regressions: 1701035
Regressions: 1701394

Verified as fixed on Windows 10 x64, macOS 10.15, Ubuntu 20.04 and on Windows 7 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: