Closed Bug 1697507 Opened 4 years ago Closed 4 years ago

Apply Proton styles to Bookmarks panel when Proton is enabled

Categories

(Firefox :: Bookmarks & History, task, P1)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 2 open bugs)

Details

(Keywords: helpwanted, Whiteboard: [proton-door-hangers])

Attachments

(1 file)

This means the Proton-style buttons at the bottom of the panel, some changes to padding and spacing, and changes to the styles of the various form fields in the panel. Details to be supplied shortly.

Marking as P1. Per experience review we agreed to mark as P1 bug the ones that will block MR1.

Priority: P3 → P1

I'm starting this now.

Assignee: nobody → mconley
Status: NEW → ASSIGNED

This updates the styling of the Bookmarks Panel for Proton, and also:

  • Fixes menulist sizes on macOS to be 32px tall for size="large", per spec
  • Makes text input elements in panels be 32px tall, per spec
Blocks: 1701096
Attachment #9211635 - Attachment description: Bug 1697507 - Restyle bookmarks panel for Proton. r?Itiel! → Bug 1697507 - Restyle bookmarks panel for Proton. r?harry!
Flags: needinfo?(htwyford)

r+!

Flags: needinfo?(htwyford)
Depends on: 1697491
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83a561e6c1d0 Restyle bookmarks panel for Proton. r=desktop-theme-reviewers,harry
Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4c83e6038430 Restyle bookmarks panel for Proton. r=desktop-theme-reviewers,harry
Regressions: 1702036
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Blocks: 1703043

Is this bug responsible for the huge expanses of blank space between Bookmark menu items, so forcing loads of uncessary scrolling and making life difficult for people suffereing from RSI ?

If yes, then please supply information so it can be fixed.
I had fixed this defect in design by forcing all preference references to 'proton' as 'false', but something is bypassing this in version 91 and the Support Forum is starting to ask for solution.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: