Find bar checkbox labels should use different colour (#5b5b66 on light, #bfbfc9 on dark)
Categories
(Toolkit :: Find Toolbar, defect, P2)
Tracking
()
People
(Reporter: Gijs, Assigned: Mardak)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-foundations] [proton-modals] [proton-door-hangers] [priority:2a] [proton-uplift])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
These colours are specced but we haven't yet implemented them. Doing so might be tricky given a variety of background on which the label text can appear.
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Bug 1699550 approximated the different color with opacity for doorhangers.
Assignee | ||
Comment 3•3 years ago
|
||
The dependent bugs so far have adjusted the colors for modals and panels. There are other places that have not been updated like infobar/findbar and in-content pages -- although unclear if it's desired to change the colors for about:preferences as the checkbox+label can be the main thing to interact with.
So maybe just findbar for now?
Unclear if it's useful to have a var with fallback 30% transparency, e.g.,
color: var(--checkbox-label-color, color-mix(in srgb, currentColor 70%, transparent));
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fbae5e36471b Update findbar labels and placeholder to be appropriately transparent for light and dark r=dao,emalysz,harry
Updated•3 years ago
|
Comment 6•3 years ago
|
||
Backed out for casuing failures at browser_ext_themes_findbar.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/f8cb1694d6629d9b3b084f109ee5236d4df2956c
Failure log: https://treeherder.mozilla.org/logviewer?job_id=337881421&repo=autoland
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/99c997f0f0c0 Update findbar labels and placeholder to be appropriately transparent for light and dark r=dao,emalysz,harry
Comment 8•3 years ago
|
||
bugherder |
Assignee | ||
Comment 9•3 years ago
|
||
Comment on attachment 9217327 [details]
Bug 1703043 - Update findbar labels and placeholder to be appropriately transparent for light and dark r=dao!
Beta/Release Uplift Approval Request
- User impact if declined: Wrong colors for proton findbar text/buttons/checkboxes
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: 1. Open find bar
- See appropriate colors (slightly lighter than regular toolbar/bookmark toolbar text)
- List of other uplifts needed: Maybe bug 1705849 and bug 1703957 as they touched adjacent lines
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): CSS / theme-json color changes
- String changes made/needed: none
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Comment on attachment 9217327 [details]
Bug 1703043 - Update findbar labels and placeholder to be appropriately transparent for light and dark r=dao!
Approved for 89 beta 6, thanks.
Comment 11•3 years ago
|
||
bugherder uplift |
Comment 12•3 years ago
|
||
Confirming as verified fixed on 90.0a1(20210505215208) and 89.0b8(20210504185920). Verified using macOS 11, Win10x64 and Ubuntu 20.
Description
•