Closed Bug 1697869 Opened 4 years ago Closed 4 years ago

Remove "exit" logic from target actors

Categories

(DevTools :: Framework, task)

Product:
DevTools
Component:
Framework
Type:
task

Tracking

(firefox88 fixed)

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1697869 - [devtools] Unify all destroy-alike sequences in target actors.
(deleted), text/x-phabricator-request
Details

Bug 1673328 removed this logic within the thread actor, but we still have this pattern in the BrowsingContexTargetActor and a few leftovers in other targets.

This logic gets in the way for bug 1631451 as it creates many codepath leading to the destruction of the target actor, while all should do the exact same thing. But today there is subtle differences. This may lead to half destroyed target actor, where the actor is cleaned up but not destroyed in a protocol.js term.

Assignee: nobody → poirot.alex

For now, we have:

  • detach
  • exit
  • destroy
    all complexly interleaved.
    Some detach and exit won't lead to actor destruction, and may lead to pending actor
    still registered in pools...

For now, we have:

  • detach
  • exit
  • destroy
    all complexly interleaved.
    Some detach and exit won't lead to actor destruction, and may lead to pending actor
    still registered in pools...
Attachment #9208552 - Attachment is obsolete: true
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c5af5dd0358
[devtools] Unify all destroy-alike sequences in target actors. r=nchevobbe

https://hg.mozilla.org/mozilla-central/rev/5c5af5dd0358

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: