Remove "exit" logic from target and thread actors
Categories
(DevTools :: Debugger, enhancement, P3)
Tracking
(firefox84 fixed)
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
The target and thread actors are having two distinct destroy sequences:
- exit
https://searchfox.org/mozilla-central/source/devtools/server/actors/thread.js#379
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#629 - destroy
https://searchfox.org/mozilla-central/source/devtools/server/actors/thread.js#339
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#619
This is confusing as I'm not sure we have any reason to have two distinct destroy sequences anymore? At least not from the Target point of view.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
We no longer need to manuall call threadActor.exit from Target Actors
as the ThreadActor is managed by the Target Actors, so that managed children
will be destroyed when the target actor is destroyed.
|
|
Assignee | |
Comment 3•4 years ago
|
||
This was hacking the internals of RDP/protocol.js in order to provide
different names to the actor prototype.
I had to rename existing sources getter to _sources in order to avoid
name collision with onSources which became sources.
(similar thing for skipBreakpoints)
I also had to tweak a few method arguments as they weren't following protocol.js spec.
They were called without protocol.js automatic marshalling of values.
Finally, hack something in protocol.js in order to avoid duplicated response for ThreadActor.attach.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 4•4 years ago
|
||
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d8ad7afc62a [devtools] Drop unused ThreadActor.detach method. r=nchevobbe,devtools-backward-compat-reviewers https://hg.mozilla.org/integration/autoland/rev/6d8c713f1434 [devtools] Drop ThreadActor.exit in favor of destroy. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/f560d280f658 [devtools] Rename TabSources to SourcesManager. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/b0a13898111c [devtools] Stop using requestTypes in ThreadActor. r=nchevobbe
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8d8ad7afc62a
https://hg.mozilla.org/mozilla-central/rev/6d8c713f1434
https://hg.mozilla.org/mozilla-central/rev/f560d280f658
https://hg.mozilla.org/mozilla-central/rev/b0a13898111c
|
||
Updated•3 years ago
|
Description
•