Closed Bug 1699354 Opened 4 years ago Closed 4 years ago

s/GetCrossDocParentFrame/GetCrossDocParentFrameInProcess/ in FrameLayerBuilder.cpp

Categories

(Core :: Web Painting, task)

task

Tracking

()

RESOLVED FIXED
88 Branch
Fission Milestone M7a
Tracking Status
firefox88 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

Per bug 1698680, we're adding a new wrapper-API called GetCrossDocParentFrameInProcess(), and we're migrating existing GetCrossDocParentFrame() calls to use the new function, after checking that they're OK with the fact that it doesn't cross processes for cross-origin content.

I'm filing this bug to convert the callers in FrameLayerBuilder.cpp.

This patch doesn't change behavior; it's just switching us between two
functions that do the same thing. (One is literally a trivial wrapper for the
other.)

We're using the new "InProcess" version of this API as a way of annotating
callsites that have been vetted as behaving properly in out-of-process iframes.

The calls in FrameLayerBuilder.cpp seem to be about deciding how best to form
layers from our frame tree. A layer tree and its associated frames will
always be restricted to all live in a particular process, so it's fine
that we're not able to reach other processes when we're making these decisions.

Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/768c11f90047 Use "InProcess" version of GetCrossDocParentFrame() in FrameLayerBuilder.cpp. r=mstange
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

Setting Fission Milestone to M7a (the current Beta milestone) because this bug is blocking meta bug 1599913 which is a blocker for Fission M7a.

Fission Milestone: --- → M7a
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: