It just works fine in the same process, it doesn't mean GetCrossDocParentFrameCrossProcess, we might want to rename the original one to GetCrosssDocParentFrameInProcess.

Hiro, do you know who can work on this to audit the usages to ensure they are not expected to work cross-processes, and also rename the method for clarity?

I believe everyone in our layout team should be able to work on this. I will recruit a volunteer on this tomorrow in Matrix.

I can take a look at auditing some of the callers tomorrow.

tnikkel, which Fission milestone should this bug block: Fission Beta or Release?

Should bug 1699902 also block Fission?

(In reply to Chris Peterson [:cpeterson] from comment #4)

tnikkel, which Fission milestone should this bug block: Fission Beta or Release?

That's hard to say because we don't know what issues the audit would uncover, but it seems like if there were significant issues they would have come up already, so release seems okay.

Should bug 1699902 also block Fission?

Yes.

(In reply to Timothy Nikkel (:tnikkel) from comment #5)

(In reply to Chris Peterson [:cpeterson] from comment #4)

tnikkel, which Fission milestone should this bug block: Fission Beta or Release?

That's hard to say because we don't know what issues the audit would uncover, but it seems like if there were significant issues they would have come up already, so release seems okay.

Since we won't know if there are significant issues until we audit the code, let's try to audit the code before our next Fission Beta milestone (M7a). If there are serious issues found, we'll then have time to fix them for M7a.

Daniel, I see that you created multiple sub-bugs, most of which are now fixed - thank you!
Is the audit complete at this point or are there callers still left to be accounted for?

It's not complete.

Note, the calls in nsDOMWindowUtils.cpp (for nsDOMWindowUtils::ZoomToFocusedInput and its helper CollectScrollableAncestors) are basically covered by bug 1649440.

Rolling over the remaining Fission M7a bugs to the Fission M8 milestone.

This bug is a soft blocker for Fission M8. We'd like to fix it before our M8 Release experiment, but we won't delay the experiment waiting for it.

For reference, the remaining callsites here are https://searchfox.org/mozilla-central/search?q=GetCrossDocParentFrame(&path=

(Ideally all of those will eventually move to this list, if they all pass the audit:
https://searchfox.org/mozilla-central/search?q=GetCrossDocParentFrameInProcess%28&path= )

Taking over.

Thanks Hiro!

The two calls in nsDOMWindowUtils.cpp, this and this should be handled in bug 1649440, a mobile specific one. That said, I believe those two can be replaced with the in-process version, since for bug 1649440 we'll have to take a different route to handle the cases across process boundaries.

Deferring this bug from Fission Milestone M8 to MVP. This bug doesn't need to block our Release channel experiment (M8) and we wouldn't uplift a fix to Beta 92 this late in the beta cycle.

Now I've filed bugs for all call sites of GetCrossDocParentFrame.

Setting Fission Milestone to Future because we don't need to track this meta bug as a Fission MVP blocker. All bugs blocking this meta bug have their own Fission Milestone flags set to Future or MVP.

Closing since we've already audited all call sites of the function.