Closed Bug 1699993 Opened 4 years ago Closed 4 years ago

Form fill suggestions show as blank in Dark Mode, if widget.macos.respect-system-appearance is set to true

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Platform:
All
macOS
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1697092
Tracking Flags:
Tracking Status
firefox88 --- disabled

People

(Reporter: yoasif, Unassigned)

References

(Regression)

Details

(Keywords: nightly-community, regression, Whiteboard: [mac:darkmode])

Attachments

(1 file)

Screen Shot 2021-03-30 at 4.49.05 PM.png
(deleted), image/png
Details

Steps to reproduce:

  1. Have two email addresses saved to Firefox form autofill
  2. Ensure macOS is using Dark apperance
  3. Set widget.macos.respect-system-appearance to true and restart Firefox
  4. Navigate to https://www.tohodo.com/autofill/form.html
  5. Double click inside email input on page

What happens:

Suggestions appear as a white rectangle with no visible text.

Expected result:

As with widget.macos.respect-system-appearance set to false.

status-firefox88: affected → disabled
Keywords: nightly-community
Regressed by: 1697331
Has Regression Range: --- → yes
Keywords: regression

Changing title to reflect the fact that when widget.macos.respect-system-appearance is set to true, aqua appearance is disabled.

Summary: Form fill suggestions show as blank with force aqua appearance in macOS dark appearance → Form fill suggestions show as blank with force aqua appearance disabled in macOS dark appearance
Summary: Form fill suggestions show as blank with force aqua appearance disabled in macOS dark appearance → Form fill suggestions show as blank in Dark Mode, if widget.macos.respect-system-appearance is set to true
Blocks: 1623686
OS: Unspecified → macOS
Hardware: Unspecified → All

richlistbox uses Field+FieldText (fixing Field will probably happen in bug 1698759), but there are also hardcoded colors in the autocomplete CSS: https://searchfox.org/mozilla-central/rev/e31c599135d04b33e4e0b4198bdb8a851c672199/browser/extensions/formautofill/skin/shared/autocomplete-item-shared.css#10,15,28-30

Whiteboard: [mac:darkmode]

This is partially fixed with bug 1698759. For countries where form autofill is disabled (everwhere except for the US and Canada) the dropdown is now correctly styled. Screenshot attached. When extensions.formautofill.addresses.enabled is true, we used a differently-styled Form Autofill dropdown. That one is still broken. The text at the bottom is color: var(--btn-text-color), which is FieldText. The latter bug is bug 1697092.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: