Closed Bug 1701394 Opened 4 years ago Closed 3 years ago

[Proton] RTL tabs title shift to the left when hovering the mouse over the tab

Categories

(Firefox :: Theme, defect, P2)

Firefox 89
defect
Points:
1

Tracking

()

VERIFIED FIXED
96 Branch
Tracking Status
firefox-esr91 --- verified
firefox89 --- wontfix
firefox94 --- wontfix
firefox95 --- wontfix
firefox96 --- verified

People

(Reporter: u662737, Assigned: Gijs)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [proton-tabs-bar][priority:2b])

Attachments

(3 files)

Attached video moztab1-2021-03-27_10.mp4 (deleted) —

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Hover on persian sites tab

Actual results:

tab title moves a little

Expected results:

tab title shoudn't move

Not sure if Theme is the right place for it, but I can confirm the behavior on a Persian nightly build.

Status: UNCONFIRMED → NEW
Component: Untriaged → Theme
Ever confirmed: true

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)

Possibly a dupe of bug 1701065

Yeah, the behavior I'm seeing is very similar.

Summary: [Proton] weird tab behavior on Persian sites → [Proton] RTL tabs title shift to the left when hovering the mouse over the tab
Priority: -- → P2

Please note that this issue is also reproducible on all LTR websites with RTL build.

Whiteboard: [proton-tabs-bar][priority:2b]
Severity: -- → S2
Keywords: regression
Regressed by: 1695140
Has Regression Range: --- → yes

I am not able to reproduce this anymore, so perhaps bug 1701065 did indeed fix this. Can you confirm, flod?

Flags: needinfo?(francesco.lodolo)

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #7)

I am not able to reproduce this anymore, so perhaps bug 1701065 did indeed fix this. Can you confirm, flod?

Hm, but bug 1701065 is a dupe of this bug?
In any case, I can still reproduce this daily.

You can download the Persian build and create a new profile, it should be visible even on the default start pages.
For example, it happens on https://www.mozilla.org/en-US/privacy/firefox/

Flags: needinfo?(francesco.lodolo)

Same issue for me with Arabic RTL in tabs since Proton. I hope the team fixes it.

Please note that this issue could be related to 1717319

FWIW,
The problem is caused by the following css.

https://searchfox.org/mozilla-central/source/browser/themes/shared/tabs.inc.css#456-459

.tabbrowser-tab:not(:hover) > .tab-stack > .tab-content > .tab-close-button {
    padding-inline-start: 0;
    width: 17px;
}

Removing this fixes the issue.

Romain, this makes tabs pretty hard to use for our RTL users (x-ref number of duplicates). Can we prioritize this?

Flags: needinfo?(rtestard)

This seemed to not work. So by removing the rules, it doesn't prevent more of the table title from being shown. Now when the tab is hovered more is actually visible.

Assignee: nobody → nils
Status: NEW → ASSIGNED
Attachment #9249605 - Attachment description: Bug 1701394 - Remove rules for when tab is hovered. r=jaws → Bug 1701394 - Remove rules for when tab is hovered. r?jaws
Points: --- → 1

Going to steal this because I think given the number of dupes and how it impacts the experience of RTL users, we need to fix this.

Assignee: nils → gijskruitbosch+bugs

Agreed, that makes sense to prioritize

Flags: needinfo?(rtestard)
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/9bfcfa324f1f fix tab text moving when tab label direction doesn't match UI direction, r=jaws
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Flags: qe-verify+

I was able to reproduce the issue on Win10 using Arabic build 89.0(20210524222230).
Verified as fixed on Win 10 /Ubuntu 20.4 /Mac 10.13 using Arabic build 96.0b3 (20211209163454)

Status: RESOLVED → VERIFIED
Flags: qe-verify+

Please nominate this for ESR approval when you get a chance. It grafts cleanly.

Flags: needinfo?(gijskruitbosch+bugs)

Comment on attachment 9253230 [details]
Bug 1701394 - fix tab text moving when tab label direction doesn't match UI direction, r?jaws

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Broken tab experience for pages whose title's text direction doesn't match the browser's (LTR page titles in RTL Firefox; RTL page titles in LTR Firefox). This affects a significant minority of Firefox users.
  • User impact if declined: See above
  • Fix Landed on Version: 96
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small JS/CSS-only changes that fix the jittering of the tab title only; already verified on nightly, possible fallout should be minimal / non-existent.
  • String or UUID changes made by this patch: None
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #9253230 - Flags: approval-mozilla-esr91?

Comment on attachment 9253230 [details]
Bug 1701394 - fix tab text moving when tab label direction doesn't match UI direction, r?jaws

Approved for 91.5esr.

Attachment #9253230 - Flags: approval-mozilla-esr91? → approval-mozilla-esr91+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Reproduced the issue on macOS 10.15 using an Urdu build 89.0.2 (20210622155641).
This issue is verified fixed using Firefox 91.5.0esr (20220105212146) Urdu and Arabic builds, on macOS 10.15, Ubuntu 20.04 and Windows 10 x64.

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: