Remove nsIWebBrowserChrome3 interface
Categories
(Core :: DOM: Navigation, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: enndeakin, Assigned: enndeakin)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
The SSB feature was removed by bug 1682593. This gives an opportunity to reduce and eliminate the nsIWebBrowserChrome3 interface:
- all of the implementations of shouldLoadURI and shouldLoadURIInThisProcess do nothing except return true.
- all of the implementations of onBeforeLinkTraversal do the same thing except ext-browser-content.js which checks the appTab state on the docshell instead. This appears to be so that links in sidebars open in new tabs (bug 1392210), but I think we can just use the group for this.
I think the patches here fix bug 1397820. My understanding is that the expected behaviour is that links to other domains from sidebars should open in a new tab, whether in the top-level frame in the sidebar or in subframes. This should also happen for pinned tabs (bug 1396988) but I don't fix that here.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
This also fixes links in top or in-process subframes and out-of-process subframes in extensions sidebars and panels so that they open in new tabs.
Depends on D110101
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D110102
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 4•4 years ago
|
||
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/abf5af44055d
https://hg.mozilla.org/mozilla-central/rev/da0d62a0534b
https://hg.mozilla.org/mozilla-central/rev/de070731df26
https://hg.mozilla.org/mozilla-central/rev/ad3936fb3593
Description
•