Closed Bug 1702454 Opened 4 years ago Closed 4 years ago

Re-enabling an add-on that overrides search engine parameters causes a prompt

Categories

(Firefox :: Search, defect, P2)

defect
Points:
2

Tracking

()

VERIFIED FIXED
89 Branch
Iteration:
89.1 - Mar 22 - Apr 4
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- verified

People

(Reporter: standard8, Assigned: standard8)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

In bug 1646338 we changed some things around how add-ons were prompting. We missed the fact that now when you install DDG privacy essentials, and then re-enable it, it now prompts to set as default whereas it didn't used to.

Set release status flags based on info from the regressing bug 1646338

Assignee: nobody → standard8
Status: NEW → ASSIGNED

Comment on attachment 9213114 [details]
Bug 1702454 - When re-enabling an add-on that uses search engine override, only set the override if the engine will be set as default. r?mixedpuppy!

Revision D110563 was moved to bug 1693585. Setting attachment 9213114 [details] to obsolete.

Attachment #9213114 - Attachment is obsolete: true
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3adfff3abd34 Re-enabling an add-on that overrides search engine parameters shouldn't cause a prompt. r=mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

verified fix on windows10,mac 10.15, and ubuntu 20 with the latest firefox nightly.

Status: RESOLVED → VERIFIED
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: