Closed Bug 1702613 Opened 4 years ago Closed 4 years ago

Search bar panel is not readable in High Contrast Mode

Categories

(Firefox :: Search, defect, P2)

Product:
Firefox
Component:
Search
Version:
Firefox 89
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- verified

People

(Reporter: phorea, Assigned: mak)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [proton-address-bar] [priority:2a] [a11y])

Attachments

(3 files)

search bar panel in high contrast
(deleted), image/png
Details
Bug 1702613 - Search bar panel is not readable in High Contrast Mode. r=harry
(deleted), text/x-phabricator-request
Details
image_2021-04-14_224825.png
(deleted), image/png
Details
Attached image search bar panel in high contrast (deleted) —

Note

  • Mac OSX 10.14 is not affected

Affected versions

  • Fx89.0a1 2021-04-01

Affected platforms

  • Windows 10 64-bit
  • Ubuntu 20.04

Preconditions

  • Windows: Activate OS High Contrast Theme / Ubuntu: Set OS to dark theme
  • The following prefs are enabled in about:config:
    browser.proton.enabled
    browser.proton.toolbar.enabled
    browser.proton.urlbar.enabled

Steps to reproduce

  1. Launch Firefox and enable the search bar.
  2. Observe the search bar panel

Expected result

  • Search bar panel is consistent with Proton theme

Actual result

  • Search bar panel doesn't follow OS's theme and the text is not visible

Regression range

sounds like a problem with the background, probably should not be set in high contrast.

Assignee: nobody → mak
Priority: -- → P2
Whiteboard: [proton-address-bar] → [proton-address-bar] [priority:2a] [a11y]
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/4974e0fb99f0 Search bar panel is not readable in High Contrast Mode. r=harry,desktop-theme-reviewers

https://hg.mozilla.org/mozilla-central/rev/4974e0fb99f0

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Attached image image_2021-04-14_224825.png (deleted) —

Hi marco, now its readable but bottom and right border are missing too in win10 64bit with high contrast.
should we log a separate bug for this?

Flags: needinfo?(mak)

(In reply to Pablo from comment #6)

Hi marco, now its readable but bottom and right border are missing too in win10 64bit with high contrast.
should we log a separate bug for this?

Yes, but it's probably a widget bug, our border is set to 1px solid white, but due to rounded border and moz-window-shadow there's some rounding for which the left border is drawn but the right is not. We may workaround that by removing the rounded border and shadow in high contrast. A lower priority bug will be good.

Flags: needinfo?(mak) → needinfo?(pablo.muir)

thanks, i just opened https://bugzilla.mozilla.org/show_bug.cgi?id=1705814 for that.

Flags: needinfo?(pablo.muir)

Marking as Verified fixed for Firefox 89 beta, considering the remaining work will be handled in bug 1705814.

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: