Closed Bug 1704736 Opened 4 years ago Closed 4 years ago

Call BrowsingContext#setRDMPaneOrientation in the parent process

Categories

(DevTools :: Responsive Design Mode, task)

task

Tracking

(Fission Milestone:M7a, firefox89 fixed)

RESOLVED FIXED
89 Branch
Fission Milestone M7a
Tracking Status
firefox89 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(1 file)

No description provided.
Blocks: 1704737
No longer blocks: 1704737
No longer depends on: 1704733
Summary: Set setRDMPaneOrientation BrowsingContext property in the parent process → Call BrowsingContext#setRDMPaneOrientation in the parent process

A simulateScreenOrientationChange method is created in targetConfigurationCommand
since we need to reach both the parent process (to call setRDMPaneOrientation),
and the content process in some cases (to dispatch an orientationchange event).

Another change was needed to ensure the orientation was set early enough in the
document lifecycle: when a new browsing context is created, we want to call
setRDMPanOrientation again, to "persist" the orientation. But the method bails
if browsingContext.inRDMPane isn't true, which is not the case when we get
the new browsing context.
In such case, we check if inRDMPane was true in the previous browsing context,
and we set it again on the new one, before re-applying the configuration.

Since the command needs RDM to be open to be effective, we're not adding a test
directly in the target configuration command folder, but extend an existing RDM
test to cover more cases.
Note that calling setRDMPaneOrientation on the browsing context does not apply
the orientation to iframes (See Bug 1704830), which is why we don't test it in
the test.

Depends on D111262

Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8547a3453ff2 [devtools] Call setRDMPaneOrientation in parent process. r=ochameau,devtools-backward-compat-reviewers.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Whiteboard: dt-fission-m3-mvp
Fission Milestone: --- → M7a
Regressions: 1706903
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: