Closed
Bug 1706903
Opened 4 years ago
Closed 4 years ago
JS error in target configuration when using the MBT
Categories
(DevTools :: General, defect, P3)
DevTools
General
Tracking
(firefox-esr78 unaffected, firefox88 unaffected, firefox89 wontfix, firefox90 fixed)
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox88 | --- | unaffected |
| firefox89 | --- | wontfix |
| firefox90 | --- | fixed |
People
(Reporter: jdescottes, Assigned: nchevobbe)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
STRs:
- open FF
- open MBT
- open a new FF window
ER: no error should be logged
AR: 3 errors
JavaScript error: resource://devtools/server/actors/target-configuration.js, line 111: TypeError: can't access property "inRDMPane", this._browsingContext is undefined
const rdmEnabledInPreviousBrowsingContext = this._browsingContext.inRDMPane;
However _browsingContext can be null per https://searchfox.org/mozilla-central/rev/72951aa826642f048da4c6b71b8b3e36a9606dcd/devtools/server/actors/target-configuration.js#79
this._browsingContext = this.watcherActor.browserElement?.browsingContext;
|
Reporter | |
Updated•4 years ago
|
Blocks: dbg-browser
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
|
||
Comment 2•4 years ago
|
||
Set release status flags based on info from the regressing bug 1704736
status-firefox88:
--- → unaffected
status-firefox89:
--- → affected
status-firefox90:
--- → affected
status-firefox-esr78:
--- → unaffected
|
|
Reporter | |
Updated•4 years ago
|
Severity: -- → S3
Priority: -- → P3
| Comment hidden (offtopic) |
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4796bd92fc8d
[devtools] Don't handle new browsing contexts in target configuration actor for the Browser Toolbox. r=jdescottes.
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
|
|
||
Updated•4 years ago
|
Keywords: regression
|
|
||
Comment 6•4 years ago
|
||
The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
For more information, please visit auto_nag documentation.
Flags: needinfo?(nchevobbe)
|
|
Assignee | |
Comment 7•4 years ago
|
||
the error is visible in the logs but don't cause any real harm, so no need to uplift the patch IMO
Flags: needinfo?(nchevobbe)
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•