Closed Bug 1706903 Opened 4 years ago Closed 4 years ago

JS error in target configuration when using the MBT

Categories

(DevTools :: General, defect, P3)

defect

Tracking

(firefox-esr78 unaffected, firefox88 unaffected, firefox89 wontfix, firefox90 fixed)

RESOLVED FIXED
90 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- wontfix
firefox90 --- fixed

People

(Reporter: jdescottes, Assigned: nchevobbe)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

STRs:

  • open FF
  • open MBT
  • open a new FF window

ER: no error should be logged
AR: 3 errors

JavaScript error: resource://devtools/server/actors/target-configuration.js, line 111: TypeError: can't access property "inRDMPane", this._browsingContext is undefined

https://searchfox.org/mozilla-central/rev/72951aa826642f048da4c6b71b8b3e36a9606dcd/devtools/server/actors/target-configuration.js#111

    const rdmEnabledInPreviousBrowsingContext = this._browsingContext.inRDMPane;

However _browsingContext can be null per https://searchfox.org/mozilla-central/rev/72951aa826642f048da4c6b71b8b3e36a9606dcd/devtools/server/actors/target-configuration.js#79

    this._browsingContext = this.watcherActor.browserElement?.browsingContext;
Blocks: dbg-browser
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1704736

Severity: -- → S3
Priority: -- → P3
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4796bd92fc8d [devtools] Don't handle new browsing contexts in target configuration actor for the Browser Toolbox. r=jdescottes.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(nchevobbe)

the error is visible in the logs but don't cause any real harm, so no need to uplift the patch IMO

Flags: needinfo?(nchevobbe)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: