Enable new Glean App with application ID firefox.desktop.background.update
Categories
(Data Platform and Tools :: General, task)
Tracking
(Not tracked)
People
(Reporter: nalexander, Assigned: wlach)
References
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
Application friendly name: whatever Desktop Firefox is -- I can't see it in https://probeinfo.telemetry.mozilla.org/glean/repositories.
Application ID: whatever Desktop Firefox is, with -backgroundupdate
appended. So I think that's desktop-firefox-backgroundupdate
.
Description: I don't know what this is supposed to be. Maybe:
The Desktop version of Firefox's background update tasks.
Repository URL: this lives (will live) in mozilla-central, i.e., https://github.com/mozilla/gecko-dev
Locations of metrics.yaml
files (can be many):
toolkit/mozapps/update/metrics.yaml
Locations of pings.yaml
files (can be many):
toolkit/mozapps/update/pings.yaml
Dependencies*:
glean-core
org.mozilla.components:service-glean
It's not clear to me if desktop-firefox
should be a dependency, in the light of future tickets like Bug 1703313, which would share data.
Retention Days: whatever Desktop Firefox is, or 180 if that's too long
Assignee | ||
Comment 1•4 years ago
|
||
This slack thread has some relevant context: https://mozilla.slack.com/archives/CEE12R4E8/p1618334112045000
Some care may need to be taken here, as this is not a "normal" variant (in the sense that e.g. Firefox for Android Nightly is a variant of Firefox for Android).
Comment 2•4 years ago
|
||
Comment 3•4 years ago
|
||
Hey Nick, thanks for filing this! After some discussion, we're going to expose this as a new Glean application.
Let's leave off firefox-desktop
and org.mozilla.components:service-glean
as dependencies. The former we can add later if we need to, and the latter is Android only.
Is firefox-desktop-background-updater
for app_name
acceptable?
Reporter | ||
Comment 4•4 years ago
|
||
(In reply to Frank Bertsch [:frank] from comment #3)
Hey Nick, thanks for filing this! After some discussion, we're going to expose this as a new Glean application.
Let's leave off
firefox-desktop
andorg.mozilla.components:service-glean
as dependencies. The former we can add later if we need to, and the latter is Android only.Is
firefox-desktop-background-updater
forapp_name
acceptable?
Let's make it firefox-desktop-background-update
-- i.e., no trailing r
. That matches the ping name, and in general we refer to everything as "background update".
Reporter | ||
Comment 6•4 years ago
|
||
The pings will in fact be in:
toolkit/mozapps/update/metrics.yaml
toolkit/mozapps/update/pings.yaml
This was necessary to land these patches. Sorry for the change!
Comment 7•4 years ago
|
||
Per discussion on Slack, :wlach is going to finalize this with his PR.
Updated•4 years ago
|
Comment 8•4 years ago
|
||
https://github.com/mozilla/probe-scraper/pull/304 has been merged and destination tables in BQ now exist to support this new app_id:
Ping: https://dictionary.protosaur.dev/apps/firefox_desktop_background_update/pings/background-update
Table: https://dictionary.protosaur.dev/apps/firefox_desktop_background_update/app_ids/firefox_desktop_background_update/tables/background-update
The final app_id is "firefox.desktop.background.update".
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 9•4 years ago
|
||
Since the PR has landed, I think this is done. I'll re-open if the data isn't actually present when I check on Monday. Thanks, all!
Description
•