Closed Bug 1705540 Opened 4 years ago Closed 4 years ago

Make protection panel subview headers narrower

Categories

(Firefox :: Protections UI, defect)

Desktop
Unspecified
defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: mhowell, Assigned: mhowell)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-door-hangers] )

Attachments

(1 file)

In bug 1703635 I changed how the separators in the main view of the protections panel work so that they no longer extend quite to the edges of the panel, as called for in the MR1 design specs. But I neglected the subviews, most of which have their own header or description (elements with the class .protections-popup-description), and those are still using the kind of border-based separator that I was trying to replace. These separators should all be replaced as well.

Gonna go ahead and take this one since I still have bug 1703635 kind of paged in.

Assignee: nobody → mhowell
Status: NEW → ASSIGNED

Mainly this is the easiest way to reduce the width of the separators when using
the Proton design (they look unchanged if the Proton prefs are disabled), but
it should also make any other future styling changes we might want easier too.

Pushed by mhowell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e40c2fa01489 Use toolbarseparator elements for protections panel subviews. r=desktop-theme-reviewers,harry

Backed out changeset e40c2fa01489 (bug 1705540) for conflict when backing out bug 1703012.

Backout link: https://hg.mozilla.org/integration/autoland/rev/cc9852811dd11a83fab7cc90ee5983fd1e9ad8f4

Molly, could you, please, rebase and reland?

Flags: needinfo?(mhowell)

Rebased and queued again.

Flags: needinfo?(mhowell)
Pushed by mhowell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ade1208d2a81 Use toolbarseparator elements for protections panel subviews. r=desktop-theme-reviewers,harry
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Regressions: 1710885
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: