Closed Bug 1710885 Opened 3 years ago Closed 2 years ago

Duplicate toolbar separator if protections panel cookie subview heading is hidden

Categories

(Firefox :: Protections UI, defect, P3)

Product:
Firefox
Component:
Protections UI
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- wontfix
firefox-esr102 --- wontfix
firefox88 --- unaffected
firefox89 --- wontfix
firefox90 --- wontfix
firefox104 --- wontfix
firefox105 --- wontfix
firefox106 --- verified

People

(Reporter: pbz, Assigned: itiel_yn8)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [proton-door-hangers])

Attachments

(1 file)

Bug 1710885 - Hide the toolbarseparator in the protections popup when needed r?pbz
(deleted), text/x-phabricator-request
Details

For some cookie behavior states we hide the heading of the cookie subview in the protections panel:
https://searchfox.org/mozilla-central/rev/27722db2f164add7047d7db03169966cb806e927/browser/base/content/browser-siteProtections.js#754,758,762

Before Bug 1705540 the separator was attached to the heading and therefore hidden with it. Now that we use toolbarseparator items instead, we end up with a duplicate separator if the heading is hidden.

STR:

  1. Set network.cookie.cookieBehavior to 2 (block all cookies)
  2. Visit a site that sets cookies, for example edition.cnn.com.
  3. Open the protections panel and click on "All Cookies"

Expected:
There is a separator between the heading "All Cookies Blocked" and the origin item list.

Actual:
There are two separators.

Set release status flags based on info from the regressing bug 1705540

status-firefox88: --- → unaffected
status-firefox89: --- → affected
status-firefox90: --- → affected
status-firefox-esr78: --- → unaffected
See Also: → https://jira.mozilla.com/browse/FIDEFE-1734
Whiteboard: [proton-door-hangers]
Priority: -- → P3
Has Regression Range: --- → yes
Severity: -- → S4
status-firefox90: fix-optional → wontfix
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Pushed by itiel_yn8@walla.com: https://hg.mozilla.org/integration/autoland/rev/af38252df733 Hide the toolbarseparator in the protections popup when needed r=hpeuckmann

https://hg.mozilla.org/mozilla-central/rev/af38252df733

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
Flags: qe-verify+

I managed to reproduce this issue on Firefox 105.0(build ID: 20220915150737) on macOS 12 using the STR from the Description. Verified as fixed on Firefox 106.0b7(build ID: 20221002185807) and Nightly 107.0a1(build ID: 20221003212025) on macOS 12, Windows 10, Ubuntu 22.

Status: RESOLVED → VERIFIED
status-firefox106: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: