Closed
Bug 1705934
Opened 4 years ago
Closed 4 years ago
Rename selectPills(pill) to selectSiblingPills(pill)
Categories
(Thunderbird :: Message Compose Window, task)
Thunderbird
Message Compose Window
Tracking
(thunderbird_esr78 wontfix, thunderbird89 wontfix)
RESOLVED
FIXED
90 Branch
People
(Reporter: thomas8, Assigned: thomas8)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
The function name of selectPills(pill) is irritating because there's no hint that this will select all the sibling pills (all pills in the row) rather than the pill(s) handed over in the argument.
|
Assignee | |
Comment 1•4 years ago
|
||
Bug 1705934 - Rename selectPills(pill) to selectSiblingPills(pill). r=aleca
- I moved
selectSiblingsPills()beforeselectAllPills()to maintain a logical order when we'll soon havedeselectAllPills()from bug 1663062. Pls note there might be some diff artifacts from this move because the functions are so similar. - Also corrected and improved some related function comments (like the false claim that the pill handed over to the function is the focus pill).
Assignee: nobody → bugzilla2007
Status: NEW → ASSIGNED
Attachment #9216624 -
Flags: review?(alessandro)
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9216624 [details] [diff] [review]
1705934_selectSiblingPills.diff
Review of attachment 9216624 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks.
Attachment #9216624 -
Flags: review?(alessandro) → review+
|
|
||
Updated•4 years ago
|
Target Milestone: --- → 90 Branch
|
||
Updated•4 years ago
|
status-thunderbird89:
--- → wontfix
status-thunderbird_esr78:
--- → wontfix
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/865b1ee82cfb
Rename selectPills(pill) to selectSiblingPills(pill). r=aleca
You need to log in
before you can comment on or make changes to this bug.
Description
•