Change default background colors of new-tab in Firefox 89
Categories
(Firefox :: New Tab Page, enhancement)
Tracking
()
People
(Reporter: julianwels, Assigned: julianwels)
References
(Regressed 1 open bug)
Details
Attachments
(3 files)
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
(deleted),
video/webm
|
Details | |
(deleted),
patch
|
pascalc
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
With bug 1703941 we turned on new new-tab for Firefox 89, but the final polish and proton color adjustments will come later, in Firefox 90. We should adjust the background colors temporarily for Firefox 89, so there is no color mismatch between the background and the rest of new-tab.
For the light theme, we should switch from white backgrounds to proton base-layer-02 already (#F9F9FB
) because the drop shadows alone are not enough to distinguish the cards from the background.
For the dark theme, we should keep the old background color from Firefox 88 (#2A2A2E
), as there is a color tone mismatch between the cards and the background that will get resolved in Firefox 90.
When we implement the other style changes with Firefox 90 with FIDE-437, we can change the styles again.
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 2•4 years ago
|
||
It was mentioned bug 1693819 would need to be backed out in bug 1705511 comment 0 if new tab background color is not white? Should that happen as part of this bug or are we choosing to flash the user?
Assignee | ||
Comment 3•4 years ago
|
||
Could you provide me with STRs for this flash? :) Because I can't reproduce it
I don't think I understand how the changes from bug 1693819 or this one can fix or re-introduce these flashes.
Changing #1C1B22
to #2A2A2E
should be barely perceptible. What am I missing here?
Comment 4•4 years ago
|
||
(In reply to Julian Gaibler from comment #3)
Changing
#1C1B22
to#2A2A2E
should be barely perceptible. What am I missing here?
It's because basically the whole window changes color. Here's a video with your patch and opening 10 windows for dark and light. And then again without your patch.
Updated•4 years ago
|
This should not be a blocker for MR1 or cause any backouts of fixes already landed. Please consider this out of scope for MR1.
Updated•4 years ago
|
Comment 6•3 years ago
|
||
Approval Request Comment
[Feature/Bug causing the regression]:
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]:
[Why is the change risky/not risky?]: simple ui change
Comment 7•3 years ago
|
||
Comment on attachment 9219084 [details] [diff] [review]
newtab-background.diff
This isn't on mozilla-central and the patch has conflict markers in it.
Updated•3 years ago
|
Comment 9•3 years ago
|
||
(In reply to Pascal Chevrel:pascalc from comment #7)
Comment on attachment 9219084 [details] [diff] [review]
newtab-background.diffThis isn't on mozilla-central and the patch has conflict markers in it.
Ah, I was under the impression it needed to be on beta. Also new to mercurial so that was my mistake. I will reattach a diff from central.
Comment 10•3 years ago
|
||
Backed out for bc failures on browser_ext_themes_ntp_colors_perwindow.js.
Failure log: https://treeherder.mozilla.org/logviewer?job_id=338183270&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/049fdf2d1e863fa19f2473c4d7c58b07235640dc
Comment 12•3 years ago
|
||
Comment 13•3 years ago
|
||
bugherder |
Assignee | ||
Comment 14•3 years ago
|
||
Comment on attachment 9217078 [details]
Bug 1706360 - Adjust default background colors of new-tab.
Beta/Release Uplift Approval Request
- User impact if declined: Visual disparity on the (rather prominent) new-tab page.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): not risky, since it's just simple style changes
- String changes made/needed:
Comment 16•3 years ago
|
||
Comment on attachment 9217078 [details]
Bug 1706360 - Adjust default background colors of new-tab.
Low risk, approved for 89 beta 9, thanks.
Comment 17•3 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Description
•