Apply proton white background to tabbrowser empty browser background
Categories
(Firefox :: Tabbed Browser, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: RT, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-foundations] [priority:2a])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Context:
While about: pages are not directly in scope for Proton, Proton visual design changes impacted about: pages given shared style pages exist. This will cause about: pages to inherit Proton styles that won't have good contrast with current background color.
Acceptance criteria:
- Apply white background to about: pages
|
Reporter | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Comment 1•4 years ago
|
||
(Do we also intend to use white in dark mode, or should we use the dark background colour, or black?)
|
|
Reporter | |
Comment 2•4 years ago
|
||
Flagging here Aaron to make sure it's part of the dark mode spec
|
||
Comment 3•4 years ago
|
||
This is relatively straightforward to do, these variables need updating:
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css
https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/browser/themes/shared/tabs.inc.css#41-56
https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/layout/style/res/plaintext.css#24-25
|
Assignee | |
Comment 4•4 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #3)
This is relatively straightforward to do, these variables need updating:
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css
This already happened in bug 1693276 which you reviewed, right?
https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/browser/themes/shared/tabs.inc.css#41-56
https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/layout/style/res/plaintext.css#24-25
The second one is dark mode only, so I don't think it needs changing in this bug. The dark mode bug should probably update it.
|
|
||
Comment 5•4 years ago
|
||
(In reply to :Gijs (he/him) from comment #4)
(In reply to Tim Nguyen :ntim from comment #3)
This is relatively straightforward to do, these variables need updating:
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css
This already happened in bug 1693276 which you reviewed, right?
Yes.
https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/browser/themes/shared/tabs.inc.css#41-56
https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/layout/style/res/plaintext.css#24-25The second one is dark mode only, so I don't think it needs changing in this bug. The dark mode bug should probably update it.
Sounds fine, worth adding a note on that bug. The first one still needs updating though for the light mode at least.
|
|
Assignee | |
Comment 6•4 years ago
|
||
|
||
Comment 7•4 years ago
|
||
The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.
|
|
||
Updated•4 years ago
|
|
|
Reporter | |
Updated•4 years ago
|
|
|
Reporter | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 8•4 years ago
|
||
|
||
Updated•4 years ago
|
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
Description
•