Closed Bug 1706483 Opened 4 years ago Closed 4 years ago

Make some more debugger tests work with native menus

Categories

(Core :: Widget: Cocoa, task)

Product:
Core
Component:
Widget: Cocoa
Platform:
All
macOS
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

(Whiteboard: [proton-uplift])

Attachments

(4 files)

Bug 1706483 - Make callers of selectContextMenuItem wait for the context menu to open before calling selectContextMenuItem. r=jdescottes
(deleted), text/x-phabricator-request
Details
Bug 1706483 - Make openContextMenuSubmenu wait for the submenu to open. r=harry
(deleted), text/x-phabricator-request
Details
Bug 1706483 - Use openContextMenuSubmenu and activateItem in browser_dbg-watchpoints.js. r=#mac-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1706483 - In browser_dbg-watchpoints.js and browser_dbg-blackbox-all.js, make sure the menu is open before calling openContextMenuSubmenu or selectContextMenuItem on it. r=#mac-reviewers
(deleted), text/x-phabricator-request
Details
No description provided.

This makes it work with native menus, which open asynchronously and which do not
support EventUtils.synthesizeMouseAtCenter on menuitems.

Attachment #9217214 - Attachment description: Bug 1706483 - Make expandAllSourceNodes wait for the context menu to open and then call activateItem. r=jdescottes → Bug 1706483 - Make callers of selectContextMenuItem wait for the context menu to open before calling selectContextMenuItem. r=jdescottes

Without this, devtools/client/debugger/test/mochitest/browser_dbg-watchpoints.js
was timing out for me locally with non-native menus.

Depends on D112826

Summary: Make debugger tests browser_dbg-fission-frame-sources.js and browser_toolbox_backward_forward_navigation.js work with native menus → Make some more debugger tests work with native menus
Blocks: 1704628
Attachment #9217235 - Attachment description: Bug 1706483 - Use activateItem in browser_dbg-watchpoints.js. r=#mac-reviewers → Bug 1706483 - Use openContextMenuSubmenu and activateItem in browser_dbg-watchpoints.js. r=#mac-reviewers
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/09a8cbbf6373 Make callers of selectContextMenuItem wait for the context menu to open before calling selectContextMenuItem. r=jdescottes https://hg.mozilla.org/integration/autoland/rev/583cf0746e25 Make openContextMenuSubmenu wait for the submenu to open. r=harry https://hg.mozilla.org/integration/autoland/rev/ab51ffaaa218 Use openContextMenuSubmenu and activateItem in browser_dbg-watchpoints.js. r=mac-reviewers,harry https://hg.mozilla.org/integration/autoland/rev/6afd3dc2b375 In browser_dbg-watchpoints.js and browser_dbg-blackbox-all.js, make sure the menu is open before calling openContextMenuSubmenu or selectContextMenuItem on it. r=mac-reviewers,bradwerth
Regressions: 1706742
Blocks: 1706725
Regressions: 1706765
Regressions: 1706766
Whiteboard: [proton-uplift]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: