Closed Bug 1706725 Opened 4 years ago Closed 4 years ago

Fix remaining debugger test failures with native menus by waiting for asynchronous menu openings.

Categories

(Core :: Widget: Cocoa, task)

Product:
Core
Component:
Widget: Cocoa
Platform:
All
macOS
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

(Whiteboard: [proton-uplift])

Attachments

(1 file)

Bug 1706725 - Add necessary waitForContextMenu(dbg) calls to these debugger tests to make them work with native context menus. r=#mac-reviewers
(deleted), text/x-phabricator-request
Details

Bug 1706472 made activateItem throw an exception if it's called before the menu is open.

As a result, a number of debugger tests have started failing, when native menus are enabled:

  • devtools/client/debugger/test/mochitest/browser_dbg-blackbox-original.js
  • devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-actions.js
  • devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-columns.js
  • devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-cond-source-maps.js
  • devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-cond.js
  • devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-debugger-statement.js
  • devtools/client/debugger/test/mochitest/browser_dbg-breakpoints.js
  • devtools/client/debugger/test/mochitest/browser_dbg-console-eval.js
  • devtools/client/debugger/test/mochitest/browser_dbg-continue-to-here.js
  • devtools/client/debugger/test/mochitest/browser_dbg-restart-frame.js

(Prior to bug 1706472, these tests would have passed but would have left an open menu behind, because activateItem wouldn't have closed the menu because it was called too early).

Bug 1706483 added a waitForContextMenu() helper. Using this, we should be able to make those tests green again.

Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/daa605aa9727 Add necessary waitForContextMenu(dbg) calls to these debugger tests to make them work with native context menus. r=mac-reviewers,bradwerth
Depends on: 1706483
Regressions: 1706791

https://hg.mozilla.org/mozilla-central/rev/daa605aa9727

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Whiteboard: [proton-uplift]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: