at the start of a double tap zoom animation don't ask content to render at the after resolution
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
(Whiteboard: [proton-uplift])
Attachments
(2 files)
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
This is a waste because we don't render that content, and if we did (we do sometimes, and it leads to flashing) it would be low resolution in the case of zooming out. It also causes bugs like bug 1698537. And if we get some other updates in there we can get stuck in a state where we half think we are zoomed in and half think we are zoomed out.
See bug 1698537, comment 11 for full back story.
|
Assignee | |
Comment 1•3 years ago
|
||
This is a waste because we don't render that content, and if we did (we do sometimes, and it leads to flashing) it would be low resolution in the case of zooming out. It also causes bugs like bug 1698537. And if we get some other updates in there we can get stuck in a state where we half think we are zoomed in and half think we are zoomed out.
See bug 1698537, comment 11 for full back story.
Depends on D113073
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f75bd775447 Don't request content paint at the "after" resolution when starting a zoom animation. r=botond https://hg.mozilla.org/integration/autoland/rev/f2f62fc8df59 Add test. r=botond
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0f75bd775447
https://hg.mozilla.org/mozilla-central/rev/f2f62fc8df59
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 5•3 years ago
|
||
Comment on attachment 9217625 [details]
Bug 1706868. Don't request content paint at the "after" resolution when starting a zoom animation. r?botond
Beta/Release Uplift Approval Request
- User impact if declined: during double tap animation shows a frame at the start of what it should look like at the end on some websites (not hard to trigger), pretty ugly
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): removes a paint at the "wrong" resolution
- String changes made/needed:
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 6•3 years ago
|
||
Comment on attachment 9217625 [details]
Bug 1706868. Don't request content paint at the "after" resolution when starting a zoom animation. r?botond
Approved for 89 beta 7, thanks.
|
|
||
Updated•3 years ago
|
|
|
||
Comment 7•3 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-beta/rev/527d6eab80e9
https://hg.mozilla.org/releases/mozilla-beta/rev/c13a73694a2c
Description
•