Closed Bug 1707806 Opened 3 years ago Closed 3 years ago

refactor the content request repaint in AsyncPanZoomController::ZoomToRect

Categories

(Core :: Panning and Zooming, task)

Product:
Core
Component:
Panning and Zooming
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

Bug 1707806. Have AsyncPanZoomController::ZoomToRect just call RequestContentRepaint instead of repeating it. r?botond
(deleted), text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details

One slightly change is needed to RequestContentRepaint.

Depends on D113074

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/676c4ed7cf77
Have AsyncPanZoomController::ZoomToRect just call RequestContentRepaint instead of repeating it. r=botond

https://hg.mozilla.org/mozilla-central/rev/676c4ed7cf77

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9218554 [details]
Bug 1707806. Have AsyncPanZoomController::ZoomToRect just call RequestContentRepaint instead of repeating it. r?botond

Beta/Release Uplift Approval Request

  • User impact if declined: maybe some checkerboarding during double tap zoom animation
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): slightly better computation of displayport during double tap zoom so that it is like during pinch zoom (which has been enabled on release for at least 6 months now)
  • String changes made/needed:
Attachment #9218554 - Flags: approval-mozilla-beta?

Comment on attachment 9218554 [details]
Bug 1707806. Have AsyncPanZoomController::ZoomToRect just call RequestContentRepaint instead of repeating it. r?botond

Does not look too scary for our last early betas, approved for 89 beta 11, thanks.

Attachment #9218554 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: