Closed Bug 1708866 Opened 4 years ago Closed 3 years ago

Adjust padding and set minimum size for Downloads panel and sub panel

Categories

(Firefox :: Downloads Panel, enhancement, P3)

Firefox 89
Desktop
Unspecified
enhancement
Points:
3

Tracking

()

VERIFIED FIXED
93 Branch
Tracking Status
firefox93 --- verified

People

(Reporter: amylee, Assigned: bigiri)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-door-hangers] [proton-cleanups])

Attachments

(1 file)

Padding adjustments and specification for minimum height of sub-panel for downloads

Please see spec for reference

https://www.figma.com/file/FjUe6ORvXZgJvI3rPuTV33/Desktop-UI-Mozilla-Confidential?node-id=11542%3A7

Hi Amy! I am an outreachy applicant. Can I work on this bug?
Thanks.

(In reply to Vaidehi from comment #1)

Hi Amy! I am an outreachy applicant. Can I work on this bug?

Unfortunately this bug is probably not suitable.

(In reply to Amy Lee [:amylee] UX from comment #0)

Padding adjustments and specification for minimum height of sub-panel for downloads

Amy: for further issues please use the proton whiteboard tags and blocking bugs when filing proton issues like this one. As it is, this bug was lost for nearly 2 weeks...

Severity: -- → N/A
Type: defect → enhancement
Whiteboard: [proton-door-hangers] [proton-cleanups]
Priority: -- → P3
Points: --- → 3
Assignee: nobody → bigiri
Status: NEW → ASSIGNED

Changed the size and padding to match the figma mock up.

Attachment #9236907 - Attachment description: WIP: Bug 1708866 - Adjust padding and minimum size in Download Panel → Bug 1708866 - Adjust padding and minimum size in Download Panel
Attachment #9236907 - Attachment description: Bug 1708866 - Adjust padding and minimum size in Download Panel → Bug 1708866 - Adjust padding and minimum size in Download Panel r=Itiel
Blocks: 1715001
Pushed by bigiri@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38aa7d0b471f Adjust padding and minimum size in Download Panel r=desktop-theme-reviewers,dao

Backed out for causing mochitest failures in browser_downloads_panel_height

Backout link: https://hg.mozilla.org/integration/autoland/rev/41af88f6fae5aa8df07dfd93e1058e661c0b6784

Push with failures

Failure log

Flags: needinfo?(bigiri)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
Flags: needinfo?(bigiri)

The padding adjustment done looks ok across all 3 OSs (windows, ubuntu and macOS) and was verified as part of QA-1075 work.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: