Easier to misclick download main action when attempting to click download secondary action after proton redesign
Categories
(Firefox :: Downloads Panel, defect, P3)
Tracking
()
People
(Reporter: hong620, Assigned: Gijs)
References
(Blocks 2 open bugs, Regression)
Details
(Keywords: regression, Whiteboard: [proton-cleanups][proton-modals])
Attachments
(2 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0
Steps to reproduce:
Click the right space of 'Downloaded File' in 'Download List GUI'
Actual results:
it open the File itself
Expected results:
it should open a 'File Saved Directory' just like FF before transaction to NEW UI
in almost of times, need to percise adjust click space to proper function call.
it's sacrifice massive lower the productivity.
Comment 1•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::File Handling' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
Comment 2•3 years ago
|
||
Reproduced on the latest versions of Firefox Nightly 91.0a1 (2021-06-10), beta 90.b5 and release 89.0.
Setting flags and a severity of S4.
Not a regression since it's the new Proton design.
Assignee | ||
Comment 3•3 years ago
|
||
This was deliberately changed in bug 1706777.
Katie, the designs for the new downloads panel suggested using the "ghost button" style here. Do we want to keep doing this? In principle (with some work) we could make this behave similarly to e.g. the main browser window hamburger button and back button - that is, we could treat some of the area around the visual hover state of the button as also hovering the button, rather than the main download panel action (see also attachment 9225595 [details] from the reporter).
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Yes, agreed 2 buttons stacked on top of each other introduces an unnecessary frustration. Rather than make the click target bigger for the ghost button (show in finder / directory), let's remove the active target space for the file (open file) behind the button. This way we eliminate the issue and keep our button pattern.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 6•3 years ago
|
||
This addresses a few things:
- it doesn't really make sense to have 2 different badge implementations
for the library and the panel. Just use the panel one for the library. - remove the old badge itself
- remove a bunch of old CSS to do with the old badge
- rename the 'new' badge now it isn't new anymore
- share the badge styling between the 'all downloads' view (about:downloads
and the library) and the downloads panel - use the downloadMainArea for hover styling of the non-button bit, and
update the JS to set the downloadHoveringButton class appropriately for
this new reality. - tighten up hover styles so we don't get a weird double hover for the
blocked download case - tighten up margins of the button, badge and progress meter (see also
https://bugzilla.mozilla.org/show_bug.cgi?id=1725837). This is also
helped by the fact that the renaming means we now properly hide the
badge image when the download isn't blocked; the CSS at
https://searchfox.org/mozilla-central/rev/a1ab92e0b16631465a946b300493e75be0eacc37/browser/components/downloads/content/downloads.css#44-47
didn't apply to this badge pre-patch.
Updated•3 years ago
|
Comment 8•3 years ago
|
||
bugherder |
Comment 9•3 years ago
|
||
Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Description
•