[Proton] Close button's hover state of the chiclet is too close to the chiclet text
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
People
(Reporter: mehmet.sahin, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-address-bar] [proton-uplift])
Attachments
(3 files, 1 obsolete file)
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
|
(deleted),
image/png
|
Details |
actual_vs_expected.png
Nightly 90.0a1 (2021-05-01) (64-Bit)
MacOS
1.) Take a look at the close button's hover state
Actual: It is too close to the text.
Expected: There could be a few pixels more padding between text and button to breathe :)
Not sure if this is a recent regression?
A screenshot actual vs expected is attached.
Thanks for checking.
Looks like the close button just only needs to be moved a few pixels to the right, so that it is nicely centered between the text and the chiclet border. That would fix that problem :)
If a recent regression, maybe caused by bug 1708533 ?
Definitely a recent regression and probably caused by bug 1708533. I was able to reproduce by updating a few days old Nightly to todays Nightly. The button was before nicely centered between text and border.
htwyford@: Can you please take a look at this issue? Many thanks in advance :)
|
||
Comment 4•4 years ago
|
||
This is actually correct according to the spec, we'll have to ask to update the spec if it's not good.
(In reply to Marco Bonardo [:mak] from comment #4)
This is actually correct according to the spec, we'll have to ask to update the spec if it's not good.
Okay, thank you :)
|
Assignee | |
Comment 6•4 years ago
|
||
UX says we're good to move the close button 2px to the right.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 7•4 years ago
|
||
|
|
Assignee | |
Comment 8•4 years ago
|
||
Comment on attachment 9219874 [details]
Bug 1708960 - Increase search mode chiclet title's margin-inline-end by 2px. r?Mak!
Beta/Release Uplift Approval Request
- User impact if declined: UX papercut in Proton.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Tiny CSS change (increasing a margin by 2px).
- String changes made/needed:
|
|
Assignee | |
Comment 10•4 years ago
|
||
(In reply to Harry Twyford [:harry] from comment #8)
- Why is the change risky/not risky? (and alternatives if risky): Tiny CSS change (increasing a margin by 2px).
To elaborate on this, the change is scoped to a single element and is well-understood.
|
||
Comment 11•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
|
Reporter | |
Comment 12•4 years ago
|
||
Thanks. Looks good now :)
|
|
||
Comment 13•4 years ago
|
||
Comment on attachment 9219874 [details]
Bug 1708960 - Increase search mode chiclet title's margin-inline-end by 2px. r?Mak!
Low risk, approved for 89 beta 8, thanks.
|
|
||
Comment 14•4 years ago
|
||
| bugherder uplift | ||
|
||
Comment 15•4 years ago
|
||
verified fix on windows10 64bit, ubuntu 20 and MacOs 10.14 using firefox nightly 90.0a1 and Beta 89.0b8
Description
•