[Double-tap to zoom] Zoom in and out transition happens a bit to fast
Categories
(Core :: Panning and Zooming, enhancement)
Tracking
()
People
(Reporter: emilghitta, Assigned: tnikkel)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
Affected versions
- Firefox 90.0a1 (BuildId:20210504214950)
- Firefox 89.0b8 (BuildId:20210504185920)
Affected platforms
- macOS 10.15
- macOS 11
Unaffected platforms
- Windows 10 64bit.
- Ubuntu 20.04 64bit.
Steps to reproduce
- Launch Firefox.
- Access any webpage.
- Double tap to zoom in a certain area of the webpage.
- Double tap to zoom out of that area.
Expected result
- The zoom in & out transition happens a bit too fast. Personally (with emphasis on personally), I find it a bit “eye stressing”.
Actual result
- We might want to consider lowering the zoom in & out transition speed a bit (at least to get closer to Safari).
Regression Range
- I don’t think that this is a regression. This behavior was also noticed in https://bugzilla.mozilla.org/show_bug.cgi?id=1698537#c5
Assignee | ||
Comment 1•3 years ago
|
||
It's controlled via the pref apz.zoom_animation_duration_ms so we can change this easily. What value do people think is good?
Assignee | ||
Updated•3 years ago
|
Reporter | ||
Comment 2•3 years ago
|
||
Spoke with Martin on slack yesterday about this and we decided to engage more folks to find the proper "sweet spot default value".
We managed to gather 9 responses from 9 different SoftVision folks:
1 vote for 290
3 votes for 350
1 vote for 360
1 vote for 370
1 vote for a range between 370 & 400
1 vote for 400
1 vote for 1000
Martin and I agreed on a default value of 350 to fit best.
Assignee | ||
Comment 3•3 years ago
|
||
Leaving android alone as I don't think we've looked at it.
Updated•3 years ago
|
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5fd5b1c1270 Make the double tap zoom animation 350ms long on desktop (macos). r=botond
Comment 5•3 years ago
|
||
bugherder |
Assignee | ||
Comment 6•3 years ago
|
||
Comment on attachment 9220693 [details]
Bug 1709639. Make the double tap zoom animation 350ms long on desktop (macos). r?botond
Beta/Release Uplift Approval Request
- User impact if declined: double tap animation length, the new value is what we determined is nicer
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): just changing the length of double tap animation
- String changes made/needed:
Comment 7•3 years ago
|
||
Comment on attachment 9220693 [details]
Bug 1709639. Make the double tap zoom animation 350ms long on desktop (macos). r?botond
Low risk polish for a new feature, approved for 89 beta 11, thanks.
Comment 8•3 years ago
|
||
bugherder uplift |
Description
•