Closed Bug 1709639 Opened 3 years ago Closed 3 years ago

[Double-tap to zoom] Zoom in and out transition happens a bit to fast

Categories

(Core :: Panning and Zooming, enhancement)

All
macOS
enhancement

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: emilghitta, Assigned: tnikkel)

References

Details

Attachments

(1 file)

Affected versions

  • Firefox 90.0a1 (BuildId:20210504214950)
  • Firefox 89.0b8 (BuildId:20210504185920)

Affected platforms

  • macOS 10.15
  • macOS 11

Unaffected platforms

  • Windows 10 64bit.
  • Ubuntu 20.04 64bit.

Steps to reproduce

  1. Launch Firefox.
  2. Access any webpage.
  3. Double tap to zoom in a certain area of the webpage.
  4. Double tap to zoom out of that area.

Expected result

  • The zoom in & out transition happens a bit too fast. Personally (with emphasis on personally), I find it a bit “eye stressing”.

Actual result

  • We might want to consider lowering the zoom in & out transition speed a bit (at least to get closer to Safari).

Regression Range

It's controlled via the pref apz.zoom_animation_duration_ms so we can change this easily. What value do people think is good?

Flags: needinfo?(emil.ghitta)
Flags: needinfo?(mbalfanz)

Spoke with Martin on slack yesterday about this and we decided to engage more folks to find the proper "sweet spot default value".

We managed to gather 9 responses from 9 different SoftVision folks:

1 vote for 290
3 votes for 350
1 vote for 360
1 vote for 370
1 vote for a range between 370 & 400
1 vote for 400
1 vote for 1000

Martin and I agreed on a default value of 350 to fit best.

Flags: needinfo?(mbalfanz)
Flags: needinfo?(emil.ghitta)

Leaving android alone as I don't think we've looked at it.

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5fd5b1c1270
Make the double tap zoom animation 350ms long on desktop (macos). r=botond
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9220693 [details]
Bug 1709639. Make the double tap zoom animation 350ms long on desktop (macos). r?botond

Beta/Release Uplift Approval Request

  • User impact if declined: double tap animation length, the new value is what we determined is nicer
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): just changing the length of double tap animation
  • String changes made/needed:
Attachment #9220693 - Flags: approval-mozilla-beta?

Comment on attachment 9220693 [details]
Bug 1709639. Make the double tap zoom animation 350ms long on desktop (macos). r?botond

Low risk polish for a new feature, approved for 89 beta 11, thanks.

Attachment #9220693 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: