Closed Bug 674371 Opened 13 years ago Closed 3 years ago

[meta] Support double-tap to zoom in on a section on macOS

Categories

(Firefox :: General, enhancement, P2)

Product:
Firefox
Component:
General
Platform:
Desktop
macOS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: limi, Assigned: tnikkel)

References

(Depends on 4 open bugs, Blocks 4 open bugs)

Details

(Keywords: feature-testing-meta, meta, parity-safari, Whiteboard: [mac:ux])

Attachments

(1 file)

Bug 674371. Turn on the pref for double tap to zoom on mac. r=botond
(deleted), text/x-phabricator-request
Details 
We should support double-tap to zoom in/out on a particular region of the page.
There's opportunity here not only to match whatever OS X Lion is doing, but also to increase commonality with Firefox mobile (which already supports this).

Additionally, I bey frequently use the built in OS X (pre-Lion) support for screen zooming (part of the Universal Access stuff), because it's just super handy to get to and works instantly.
Summary: Support double-tap to zoom in on a section on OS X Lion → [10.7] Support double-tap to zoom in on a section on OS X Lion
Assignee: nobody → waterlo1
Depends on: 851128
As per https://bugzilla.mozilla.org/show_bug.cgi?id=688990#c17, we'll be moving our work into an add-on.  Once OMTC / APZC is ready to go, the add-on will be deprecated.

The add-on depends on bugs 851128 and 853490.  It will be called "Multi-Touch Gestures" (or something very similar), and will be available on addons.mozilla.org before the end of April.

Unassigning myself from the bug.
Assignee: waterlo1 → nobody
Depends on: 1180706
No longer depends on: apz-desktop
Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)
Keywords: parity-safari
Whiteboard: [parity-safari]
Depends on: desktop-zoom-xp
Blocks: 1505469

I get used to this feature in chrome and I very much miss this in Firefox. I wonder why this 8 year bug in still unresolved.

Can someone recommend an already existing addon to make this happen in firefox.

This isn't really specific to Lion, updating summary.

Type: defect → enhancement
Summary: [10.7] Support double-tap to zoom in on a section on OS X Lion → Support double-tap to zoom in on a section on macOS

(In reply to sivalingam from comment #5)

I get used to this feature in chrome and I very much miss this in Firefox. I wonder why this 8 year bug in still unresolved.

Can someone recommend an already existing addon to make this happen in firefox.

It's being worked on (see recent comments in bug 789906, which is the corresponding bug for Windows).

There's also an addon linked in that bug, though people report it doesn't work very well.

I note that on mobile, we currently gate double-tap zooming on the following:

    // If the CSS viewport is narrower than the screen (i.e. width <=
    // device-width) then we disable double-tap-to-zoom behaviour.
    CSSToLayoutDeviceScale scale =
        mPresShell->GetPresContext()->CSSToDevPixelScale();
    if ((viewportInfo.GetSize() * scale).width <= screenSize.width) {
      zoomConstraints.mAllowDoubleTapZoom = false;
    }

This condition will never be true on desktop (since there is no mobile viewport sizing on desktop, the layout viewport always derives its width from the browser window's width), so we'll have to figure out what condition (if any) to gate it on for desktop.

This would really improve the UX on mac.

Hardware: x86 → Desktop

Double tap with two fingers to zoom feature is available on both Chrome and Safari. With my Logitech MX Master 3, I can even zoom with a dedicated gesture button click (they call it "Smart Zoom"). Would love to see this feature come to Firefox.

Severity: normal → N/A
Priority: -- → P2

I see bug 789906 and others have been closed, as pinch zooming went out in 83 release. 🎉 Any chance this can progressed now?

I'd love to have smart zooming, it's the functionality I miss the most from Chrome.

Yes, this is one of the follow-ups to desktop zooming we hope to work on in the near future.

Whiteboard: [mac:ux]
Depends on: 1696802

Depends on D107389

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED
Depends on: 1697416
Depends on: 1697766
Depends on: 1697786
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fbf677b3fb7e
Turn on the pref for double tap to zoom on mac. r=botond

https://hg.mozilla.org/mozilla-central/rev/fbf677b3fb7e

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Depends on: 1698537
Depends on: 1698546
Depends on: 1698642

Backed out changeset fbf677b3fb7e (bug 674371) on dev's request.

Backout:
https://hg.mozilla.org/integration/autoland/rev/65589ccfe6c2e333f1e5dce3d9c73655b9f7474d

Status: RESOLVED → REOPENED
status-firefox88: fixed → ---
Flags: needinfo?(tnikkel)
Resolution: FIXED → ---
Target Milestone: 88 Branch → ---

I requested backout of this so that we can enable this nightly only for now, which I will do in bug 1698642.

Flags: needinfo?(tnikkel)
Depends on: 1698785
Depends on: 1698841
Depends on: 1699147
Depends on: 1699180
Attachment #9207345 - Attachment description: Bug 674371. Turn on the pref for double tap to zoom on mac. r?botond → Bug 674371. Turn on the pref for double tap to zoom on mac. r=botond
Depends on: 1700064
Depends on: 1700375
Depends on: 1701597
Depends on: 1701749
Summary: Support double-tap to zoom in on a section on macOS → [meta] Support double-tap to zoom in on a section on macOS
Depends on: 1702736
Depends on: 1702851
Depends on: 1703595
Depends on: 1703804
Depends on: 1704222
Depends on: 1705260
Depends on: 1705261
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e40d9fe9190f
Turn on the pref for double tap to zoom on mac. r=botond

https://hg.mozilla.org/mozilla-central/rev/e40d9fe9190f

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Depends on: 1705976
Depends on: 1707234
Depends on: 1707389
Depends on: 1707417
Depends on: 1707557
Depends on: 1707560
Depends on: 1707802
Depends on: 1707806
Depends on: 1708649
Depends on: 1709614
Depends on: 1709639
Depends on: 1710034
Depends on: 1710050
Depends on: 1713584
Depends on: 1713589
Depends on: 1713715
Depends on: 1721601
Duplicate of this bug: 1425747
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: