Submenus for Bookmarks menu don't have rounded edges
Categories
(Firefox :: Toolbars and Customization, defect, P2)
Tracking
()
People
(Reporter: csasca, Assigned: mhowell)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-toolbar] [priority:2b])
Attachments
(3 files)
Affected versions
- Firefox 89.0b10
- Firefox 90.0a1
Affected platforms
- Windows 10
Steps to reproduce
- Launch Firefox
- Enter Customize mode and drag Bookmarks menu to the toolbar
- Save the changes and click on Bookmarks menu from the toolbar
- Hover over it to open a submenu
Expected result
- The submenus has rounded edges
Actual result
- The right part corners of the submenus are chopped and not round
Regression range
- Logged as a follow-up issue on Bug 1700194, not sure if that caused it, will see for a regression
Additional notes
- The issue can be seen in the attachment
- Seems that only Windows 10 is affected
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Reporter | ||
Comment 1•3 years ago
|
||
This seems to be introduced with the implementation of Proton "browser.proton.contextmenus.enabled" as the chopped edges can be seen in the first builds where it was first introduced.
Assignee | ||
Updated•3 years ago
|
Comment 2•3 years ago
|
||
I think Emma's patch in bug 1703051 might fix this, fwiw.
Assignee | ||
Comment 3•3 years ago
|
||
I'm not sure about that specific patch, but something has changed so that I can no longer reproduce this bug. Catalin, are you still seeing this one on current nightly?
Reporter | ||
Comment 4•3 years ago
|
||
Yep, looked over 91.0b1 and 92.0a1 (2021-07-13) and it seems that it was fixed.
Assignee | ||
Comment 5•3 years ago
|
||
Thanks for checking. Let's close this one out then!
Comment 6•3 years ago
|
||
At least on macOS there were rounded corners in the submenues of the bookmarks menu until Firefox 90. But in Firefox 91 Beta 3 and Firefox Nightly the rounded corners are missing. Unfortunately I can't run mozregression at the moment due to slow hotel internet so I will re-open this ticket to get this on your radar and because the bug summary is still true.
Comment 7•3 years ago
|
||
(In reply to Sören Hentzschel from comment #6)
At least on macOS there were rounded corners in the submenues of the bookmarks menu until Firefox 90. But in Firefox 91 Beta 3 and Firefox Nightly the rounded corners are missing. Unfortunately I can't run mozregression at the moment due to slow hotel internet so I will re-open this ticket to get this on your radar and because the bug summary is still true.
This is confusing because it's the opposite of what comment #4 says (OK, modulo 91b1 vs 91b3, but it seems unlikely the corners went missing in that timeframe). Are we sure we're talking about the same menus? I cannot reproduce the bug in attachment 9221261 [details] on 92.0a1 (2021-07-15) (64-bit) (today's nightly is not quite out yet, AFAICT).
Comment 8•3 years ago
|
||
Comment 9•3 years ago
|
||
Also, this bugreport was originally for Windows 10...
Comment 10•3 years ago
|
||
Are we sure we're talking about the same menus?
Yes, it's the same menu. I attached a screenshot.
This is confusing because it's the opposite of what comment #4 says […] Also, this bugreport was originally for Windows 10...
Maybe whatever fixed this for Windows regressed it on macOS. 🤔 I could run mozregression in a few days and file a new bug then unless someone else is faster (I am running out of time for today, sorry). For now I just wanted to let you know. 😊
Comment 11•3 years ago
|
||
(In reply to Sören Hentzschel from comment #10)
Created attachment 9231538 [details]
current nightly, macOSAre we sure we're talking about the same menus?
Yes, it's the same menu. I attached a screenshot.
This is confusing because it's the opposite of what comment #4 says […] Also, this bugreport was originally for Windows 10...
Maybe whatever fixed this for Windows regressed it on macOS. 🤔 I could run mozregression in a few days and file a new bug then unless someone else is faster (I am running out of time for today, sorry). For now I just wanted to let you know. 😊
Hm, the problem is I couldn't reproduce - the screenshot I posted is also from nightly on macOS (11.4, in case it matters), and as you can see the corners are rounded just fine. I just checked light mode, same thing. Then I removed my profile and created a new one, and then I could reproduce. Unsure what the deal is. Of course, now that I deleted the old profile I can't figure out why it worked there...
I filed bug 1720880, but I think keeping this closed is probably the least confusing, as AIUI Windows is still fine.
Description
•