Closed Bug 1720880 Opened 3 years ago Closed 3 years ago

[macOS] Corners of bookmarks toolbar menu button submenus are not rounded

Categories

(Firefox :: Toolbars and Customization, defect, P3)

Product:
Firefox
Component:
Toolbars and Customization
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox90 --- unaffected
firefox91 --- wontfix
firefox92 --- verified

People

(Reporter: Gijs, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [proton-cleanups])

Attachments

(2 files)

Bug 1720880 - Remove :-moz-lwtheme from a bookmarks popup-specific selector. r=Gijs
(deleted), text/x-phabricator-request
Details
Bug 1720880 - Consolidate a bit bookmarks popup styles. r=dao
(deleted), text/x-phabricator-request
Details

See last few comments in bug 1710556. Not sure what's going on, I'll update this bug as I find out.

Emilio, looks like bug 1716546 broke this - can you take a look?

Has Regression Range: --- → yes
status-firefox90: --- → unaffected
status-firefox91: --- → affected
status-firefox-esr78: --- → unaffected
Flags: needinfo?(emilio)
Regressed by: 1716546

Sure

Assignee: nobody → emilio
Flags: needinfo?(emilio)

With the system theme otherwise we show square corners.

Also remove a margin rule which other menupopups don't have and which feels a
bit ugly, but let me know if you want that one back (without the :-moz-lwtheme
selector).

Status: NEW → ASSIGNED

Unify shared declarations, and avoid unneeded [placespopup=true], since
there's no element that matches:

:is(#BMB_bookmarksPopup, #PlacesToolbar) menupopup:not([placespopup])

Depends on D120080

Severity: -- → S4
Priority: -- → P3
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9bea31d80fad Remove :-moz-lwtheme from a bookmarks popup-specific selector. r=Gijs,desktop-theme-reviewers,dao https://hg.mozilla.org/integration/autoland/rev/ef58d79c5818 Consolidate a bit bookmarks popup styles. r=dao

https://hg.mozilla.org/mozilla-central/rev/9bea31d80fad
https://hg.mozilla.org/mozilla-central/rev/ef58d79c5818

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox92: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Flags: qe-verify+

I have reproduced this issue using Firefox 91.0b3 on macOS 10.15.
I can confirm this issue is fixed, I verified using Firefox 92.0b2 macOS 10.15.

Status: RESOLVED → VERIFIED
status-firefox92: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: