Emit the same HTML for displaying and printing messages
Categories
(MailNews Core :: Printing, task)
Tracking
(thunderbird_esr78 unaffected)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | unaffected |
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Currently when we display a message, we convert it to HTML and display it in a browser. Then when we print the message, we convert it to different HTML and print it. We shouldn't do this, we should use the same HTML and have CSS create the different versions. This means that (a) we don't have to convert a message to HTML twice and (b) we can print the message displayed in the browser without having to jump through a lot of hoops. Converting to the new printing UI will be much easier, at the cost of cleaning out some horrible old back-end code and possibly causing regressions.
Assignee | ||
Comment 1•3 years ago
|
||
I've just realised that if I do this then extensions with message display scripts could get messed up, particularly if they do silly things like our tests do:
document.body.textContent += "Hey look, the script ran!";
Assignee | ||
Comment 2•3 years ago
|
||
I think this makes nsMimeOutput::nsMimeMessagePrintOutput obsolete, there are some uses left behind but they should behave as nsMimeOutput::nsMimeMessageBodyDisplay does.
I'm not even sure most of the remaining uses are in live code.
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
Sorry Julien, is this the bug you meant to add that to?
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
bugherder |
Comment 5•3 years ago
|
||
Hi Geoff, this bug blocks bug 1711408 so I flagged is as a Proton bug and have created the JIRA correspondingly. Hope it helps, let me know otherwise.
Comment 6•3 years ago
|
||
(In reply to Julien Chaupitre from comment #5)
Hi Geoff, this bug blocks bug 1711408 so I flagged is as a Proton bug and have created the JIRA correspondingly. Hope it helps, let me know otherwise.
Hi Julien, this bug is bug 1711408, so it cannot block itself. This bug is in MailNews Core: Printing
(Thunderbird territory), so it's unlikely that this relates to Firefox Proton UI changes, and I've never seen such links on any other Thunderbird bug.
Description
•