Closed Bug 1711844 Opened 3 years ago Closed 3 years ago

Icons in Customize menu are slightly darker than if placed on the toolbar or inside Overflow menu while Light theme is used

Categories

(Firefox :: Theme, defect, P3)

Product:
Firefox
Component:
Theme
Platform:
Desktop
All
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- wontfix
firefox88 --- unaffected
firefox89 --- wontfix
firefox90 --- wontfix
firefox92 --- wontfix
firefox93 --- wontfix
firefox94 --- verified
firefox95 --- verified

People

(Reporter: atrif, Assigned: cmkm)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [proton-icons][proton-cleanups])

Attachments

(2 files)

imgonline-com-ua-twotoone-me6sl9BOGL.jpeg
(deleted), image/jpeg
Details
Bug 1711844 - Correct customize menu icon colors. r?jhirsch
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details

Affected versions

  • 90.0a1 (20210518213628)
  • 89.0b14 (20210518190425)

Affected platforms

  • macOS 11.3.1
  • Windows 10x64

Steps to reproduce

  1. Open Firefox and observe the icons.
  2. Add one icon to the toolbar (e.g Print, Private Window, Text Encoding, Edit Controls)

Expected result

  • The Icons have the same color.

Actual result

  • Some icons are darker in Customize mode than on the toolbar or Overflow menu.

Regression range

Notes

  • Attached a screenshot.
  • The icons remains the same as in the screenshot after exiting Customize menu.
Has Regression Range: --- → yes
Has STR: --- → yes
Priority: -- → P3

Mike, can you take a look?

status-firefox90: affected → fix-optional
Flags: needinfo?(mconley)
Blocks: proton-cleanups
Flags: needinfo?(mconley)
Whiteboard: [proton-icons] → [proton-icons][proton-cleanups]

Thanks! I've put this into the cleanup queue for triage and prioritization.

Points: --- → 1
Assignee: nobody → jhirsch
Status: NEW → ASSIGNED
Assignee: jhirsch → cmeador
Pushed by jhirsch@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e85e8888096 Correct customize menu icon colors. r=jhirsch,desktop-theme-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/2e85e8888096

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

Seems like a pretty low-risk polish fix if we wanted to get it into the MR2 release. Please nominate the patch for Beta approval if you agree.

status-firefox90: fix-optional → wontfix
status-firefox92: --- → wontfix
status-firefox93: --- → wontfix
status-firefox94: --- → fix-optional
status-firefox-esr78: --- → unaffected
status-firefox-esr91: --- → wontfix
Flags: needinfo?(cmeador)

Comment on attachment 9244774 [details]
Bug 1711844 - Correct customize menu icon colors. r?jhirsch

Beta/Release Uplift Approval Request

  • User impact if declined: Minor visual/style nit in customize menu regarding icon colors
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Not risky as the bug and fix affect a styling inconsistency that doesn't impact usability
  • String changes made/needed:
Flags: needinfo?(cmeador)
Attachment #9244774 - Flags: approval-mozilla-beta?

Comment on attachment 9244774 [details]
Bug 1711844 - Correct customize menu icon colors. r?jhirsch

Approved for 94.0b5.

Attachment #9244774 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Reproduced this issue on Win 10x64 using an affected Nightly build 90.0a1 (2021-05-19), with STR from comment 0.

The issue is verified as fixed on latest Beta 94.0b5 and latest Nightly 95.0a1 under macOS 10.15, macOS 11 and Windows 10x64. All the icons have the same shade of grey. I could not reproduce this on Ubuntu 20.04.

Status: RESOLVED → VERIFIED
status-firefox94: fixed → verified
status-firefox95: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: