Closed Bug 1705849 Opened 4 years ago Closed 3 years ago

Toolbar icons in dark and light themes have 70% opacity

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: sfoster, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-icons] [proton-uplift])

Attachments

(1 file)

Bug 1705849 - Update toolbar icon fill colours for system/light/dark themes to remove opacity and match Proton spec. r?harry!
(deleted), text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details

The fill color we end up with is an rgba() value, with 0.7 in the alpha channel. This should be 1 (full opacity).

Priority: -- → P1
Assignee: nobody → mconley
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a08a2e0aee43 Update toolbar icon fill colours for system/light/dark themes to remove opacity and match Proton spec. r=harry,desktop-theme-reviewers
Blocks: 1703957

https://hg.mozilla.org/mozilla-central/rev/a08a2e0aee43

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Regressions: 1707357

Backed out for causing Bug 1707357 for Linux users.

Backout link: https://hg.mozilla.org/mozilla-central/rev/89a07f1b7f853f12ce5e97ecfb67edaa2946752c

Status: RESOLVED → REOPENED
status-firefox90: fixed → ---
Flags: needinfo?(mconley)
Resolution: FIXED → ---
Target Milestone: 90 Branch → ---
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/052b086a834c Update toolbar icon fill colours for system/light/dark themes to remove opacity and match Proton spec. r=harry
Flags: needinfo?(mconley)

https://hg.mozilla.org/mozilla-central/rev/052b086a834c

Status: REOPENED → RESOLVED
Closed: 4 years ago → 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9217197 [details]
Bug 1705849 - Update toolbar icon fill colours for system/light/dark themes to remove opacity and match Proton spec. r?harry!

Beta/Release Uplift Approval Request

  • User impact if declined: Required for MR1 / Proton
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): CSS-only change that updates some icon fill rules.
  • String changes made/needed: None.
Attachment #9217197 - Flags: approval-mozilla-beta?
status-firefox89: --- → affected
Whiteboard: [proton-icons] → [proton-icons] [proton-uplift]

Comment on attachment 9217197 [details]
Bug 1705849 - Update toolbar icon fill colours for system/light/dark themes to remove opacity and match Proton spec. r?harry!

Approved for 89 beta 6, thanks.

Attachment #9217197 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: