double tap scrolls when it should zoom out
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox89 | --- | wontfix |
| firefox90 | --- | wontfix |
| firefox91 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
Reporting at bug 1710050, comment 3.
|
Assignee | |
Comment 1•3 years ago
|
||
I think I see why now the 90% check of bug 1707560 was there, to prevent situations like this. But that bug fixed a real problem so we want to make a forward fix of this issue.
The problem happens when we take a tall element and change our rect to have the same aspect ratio as the composited area. We center the new rect on the tap point, so unless the cursor is in he center of the screen the new rect will be out of the composited area. This is fine if we actually zoom, but if we are already zoomed it will just result in scrolling, which we do not want. We want to zoom out in this situation.
Since ZoomToRect performs any scrolling and zooming to zoom to the rect we can just do that scrolling ourselves and give the two rects a common origin and then decide if we are already zoomed in as far as we can for this tap point.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D116367
|
||
Comment 3•3 years ago
|
||
Set release status flags based on info from the regressing bug 1707560
|
|
||
Updated•3 years ago
|
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/768cf94d95a9 In calculating if a rect is zoomed in shift the rect and the composited area to a common origin. r=botond,emilio https://hg.mozilla.org/integration/autoland/rev/dee157f4de04 Add test. r=emilio
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/768cf94d95a9
https://hg.mozilla.org/mozilla-central/rev/dee157f4de04
|
|
||
Comment 6•3 years ago
|
||
The patch landed in nightly and beta is affected.
:tnikkel, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
For more information, please visit auto_nag documentation.
|
||
Updated•3 years ago
|
|
||
Comment 7•3 years ago
|
||
Botond, Emilio, any opinion re comment 6?
|
|
Assignee | |
Comment 8•3 years ago
|
||
Oh, sorry, this got lost. I lean towards not uplifting it I guess.
|
|
||
Comment 9•3 years ago
|
||
Thanks Timothy!
|
||
Updated•3 years ago
|
Description
•