if double tap zoom can't find a rect to zoom in to and we are zoomed out then zoom in some small default amount
Categories
(Core :: Panning and Zooming, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(3 files)
|
Assignee | |
Comment 1•3 years ago
|
||
This provides feedback to the user, otherwise nothing happens and the user doesn't know if their input was accepted or not. This matches what Chrome does.
We add a new flag for ZoomToRect that only double tap uses. We also need to add the cursor position to the ZoomTarget struct as that is what we will be zooming in on. (CalculateRectToZoomTo has a little bit of refactoring to calculate this point sooner and without an intermediate variable.)
The rest of the patch is some logic in ZoomToRect to decide when to do this, and some math to compute the zoom to rect (which is similar to the zoom out code).
Depends on D116369
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D116370
|
|
Assignee | |
Comment 3•3 years ago
|
||
And then use this to disable the default zoom in in a couple of tests. The tablecell test specifically checks that we don't zoom in on tablecells. The hscrollable test checks that we don't scroll when double tapping and it would like to zoom out.
Depends on D116371
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5141c00e55f9 If double tap zoom can't find a rect to zoom in to and we are zoomed out then zoom in some small default amount. r=botond https://hg.mozilla.org/integration/autoland/rev/c42ac7ee8d79 Add test. r=botond https://hg.mozilla.org/integration/autoland/rev/1c7cd1f3d1cb If the double tap default zoom in pref is 1 make sure to fully disable the functionality. r=botond
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5141c00e55f9
https://hg.mozilla.org/mozilla-central/rev/c42ac7ee8d79
https://hg.mozilla.org/mozilla-central/rev/1c7cd1f3d1cb
Description
•