Open Bug 1714238 Opened 3 years ago Updated 3 years ago

Share data structure for SVGPathData::mData and nsStyleSVGRest::mD

Categories

(Core :: SVG, enhancement)

Product:
Core
Component:
SVG
Platform:
All
Unspecified
Type:
enhancement

Tracking

()

People

(Reporter: boris, Assigned: boris)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

We should use the similar data structure for both SVGPathData::mData and nsStyleSVGReset::mD (which is added by Bug 1340422). For now we still need a conversion from SVGPathData::mData to nsStyleSVGReset::mD when handling SVG d attribute on path element. If we share the same data structue (e.g. use StylePathComand everywhere), we can avoid unwanted conversion, for optimization.

Note: nsStyleSVGReset::mD uses the same data structure with offset-path path() function.

Summary: Share data structure for SVGPathData::mD and nsStyleSVGRest::mD → Share data structure for SVGPathData::mData and nsStyleSVGRest::mD
Blocks: 1744599
Assignee: nobody → boris.chiou
No longer blocks: 1744599
Depends on: 1745149
No longer depends on: 1388931

I update the dependency because this bug is still dependent on the removal of SVGPathSeg code, so we don't have to keep SVGPathData::mData for the DOM API. However, the shipment of d property is not strongly dependent on this bug (i.e. we just need to do some more conversions). So shipping the d property without this should be fine.

Blocks: svg-enhance
You need to log in before you can comment on or make changes to this bug.