Closed Bug 1717606 Opened 3 years ago Closed 3 years ago

Some follow-up changes for bug 1715512

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(6 files)

No description provided.

This simplifies the callers. Eventually replaceShape could be moved to SharedShape.

Depends on D118460

This was a footgun because the argument defaults to GENERATE_NONE, meaning it can change
a dictionary shape's object flags without allocating a new shape.

We don't rely on this anywhere for perf reasons so it's simpler and safer to always
allocate a new shape.

Depends on D118461

It's better to clear the Indexed flag in densifySparseElements directly, so that
we don't need to immediately allocate a new shape.

Depends on D118462

The lastProperty name no longer makes sense for the shape now that properties
are stored separately.

Depends on D118463

Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2139ba84a1fe part 1 - Inline Shape::setObjectFlag in JSObject::setFlag. r=jonco https://hg.mozilla.org/integration/autoland/rev/2bd82ca65e09 part 2 - Inline Shape::setProto in JSObject::setProtoUnchecked. r=jonco https://hg.mozilla.org/integration/autoland/rev/b074f6287b26 part 3 - Make replaceShape set the object's shape. r=jonco https://hg.mozilla.org/integration/autoland/rev/a78b62f28c6a part 4 - Remove setFlag's GenerateShape argument. r=jonco https://hg.mozilla.org/integration/autoland/rev/bb1dcb7d3777 part 5 - Remove NativeObject::clearFlag. r=jonco https://hg.mozilla.org/integration/autoland/rev/7a0639221c99 part 6 - Remove NativeObject::lastProperty. r=jonco
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: