[XFA] A specific PDF file is not loaded / displayed
Categories
(Firefox :: PDF Viewer, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox89 | --- | disabled |
firefox90 | --- | unaffected |
firefox91 | --- | fixed |
firefox92 | --- | verified |
People
(Reporter: danibodea, Assigned: calixte)
References
(Regression)
Details
(Keywords: regression)
Attachments
(8 files)
(deleted),
application/pdf
|
Details | |
(deleted),
application/pdf
|
Details | |
(deleted),
application/pdf
|
Details | |
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
application/pdf
|
Details | |
(deleted),
application/pdf
|
Details | |
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
text/x-github-pull-request
|
Details |
Note
- When the user loads a specific PDF, he will notice that the file will not load.
Affected versions
- Nightly v91.0a1
Affected platforms
- all
Steps to reproduce
- Launch browser.
- Flip the pdfjs.enableXfa to true.
- Load the attached PDF file.
Expected result
- The file is loaded and displayed.
Actual result
- The file is NOT loaded and displayed.
Regression range
-
This is a regression of bug 1717132; mozregression results:
2021-06-22T19:52:53.047000: DEBUG : Found commit message:
Bug 1717132 - Update pdf.js to version 2.10.146 r=marcoDifferential Revision: https://phabricator.services.mozilla.com/D118240
2021-06-22T19:52:53.047000: DEBUG : Did not find a branch, checking all integration branches
2021-06-22T19:52:53.049000: INFO : The bisection is done.
2021-06-22T19:52:53.050000: INFO : Stopped
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Comment 1•3 years ago
|
||
I've tried removing the priority, but it appears to fail. Please set the corresponding priority.
Assignee | ||
Comment 2•3 years ago
|
||
It's fixed upstream likely thanks to https://github.com/mozilla/pdf.js/commit/56a75f8b265b1ca87350382f10d4891f0a7c810a.
Updated•3 years ago
|
Updated•3 years ago
|
Reporter | ||
Comment 3•3 years ago
|
||
This issue also occurs in the case of the attached PDF.
It is also loaded in the latest Beta v90.0b11, but not properly displayed.
Left a note here to check when this bug has a fix.
Reporter | ||
Comment 4•3 years ago
|
||
Another PDF with the same behavior. This one is also not loaded in Beta v90.0b11.
Comment 5•3 years ago
|
||
Comment 6•3 years ago
|
||
The first is fixed, the other two PDFs are still failing to load.
Reporter | ||
Comment 7•3 years ago
|
||
(In reply to Marco Castelluccio [:marco] from comment #6)
The first is fixed, the other two PDFs are still failing to load.
I confirm this on all platforms.
Reporter | ||
Comment 8•3 years ago
|
||
This issue also occurs in the case of the attached PDF.
Reporter | ||
Comment 9•3 years ago
|
||
A different PDF that won't load was discovered.
Please let us know if you want them logged sepparately.
Comment 10•3 years ago
|
||
Assignee | ||
Comment 11•3 years ago
|
||
About PDFIUM-292-0.pdf
: during binding process some nodes are identified thanks to SOM expressions (a kind of XPath) and those expressions can can contain some JS code, for example:
$.COMMAND.sendApplicationInformationRequest.prospectApplication.prospectParty.(typeName.value== "additionalInsured")
In this expression the sub-expression between parenthesis is a JS expression and for now embedded JS is not evaluated.
So in this case we should smartly fail and skip the current binding.
About sumatrapdf-1546-0-GOOD.pdf
, it's working ok with upstream pdf.js on master: I'd say it has been fixed thanks to:
https://github.com/mozilla/pdf.js/commit/5f76b6370c91d7a4358edffb9caac667af9dd680
About 08ba1dad-3244-4854-b0a9-00347e016306.pdf
and 8cf6c672-3cad-4733-80c4-0f2e848b5ebf.pdf
, they've been fixed few days ago and they're in pdf.js test suite.
Comment 12•3 years ago
|
||
Comment 13•3 years ago
|
||
Can you verify all PDFs from this bug, except PDFIUM-292-0.pdf, are fixed?
Reporter | ||
Comment 14•3 years ago
|
||
(In reply to Marco Castelluccio [:marco] from comment #13)
Can you verify all PDFs from this bug, except PDFIUM-292-0.pdf, are fixed?
Yes, I can confirm that. All PDFs reported are being fixed except the last one.
We can keep this bug open for the last PDF or we can close it and open a clone for the remaining issue.
Which one is preferable?
Testing Results:
- 2ee7f078-0324-4012-b4b1-6a4925cc17f5.pdf - fixed; loads and displays.
- 08ba1dad-3244-4854-b0a9-00347e016306.pdf - partially fixed; loads and displays a first page, but does not work properly.
- 8cf6c672-3cad-4733-80c4-0f2e848b5ebf.pdf - partially fixed; loads and displays a first page, but does not work properly.
- sumatrapdf-1546-0-GOOD.pdf - partially fixed; loads and displays a first page, but does not work properly.
- PDFIUM-292-0.pdf - NOT fixed; still does not load!
Assignee | ||
Comment 15•3 years ago
|
||
08... & 8c... are dynamic so from a static pov, I'd say they're fixed but we can open a new bug for the JS part.
About sumatra... could you elaborate ?
And about PDFIUM... I've a WIP locally.
Updated•3 years ago
|
Assignee | ||
Comment 16•3 years ago
|
||
The issue for the PDFIUM... file has been addressed in:
https://github.com/mozilla/pdf.js/pull/13687
Updated•3 years ago
|
Reporter | ||
Comment 17•3 years ago
|
||
(In reply to Calixte Denizet (:calixte) from comment #15)
08... & 8c... are dynamic so from a static pov, I'd say they're fixed but we can open a new bug for the JS part.
About sumatra... could you elaborate ?
And about PDFIUM... I've a WIP locally.
I've logged new bugs for the remaining issues:
- 2ee7f078-0324-4012-b4b1-6a4925cc17f5.pdf
** fixed; loads and displays correctly;
** remaining static field issues found: bug 1720660, bug 1720664. - 08ba1dad-3244-4854-b0a9-00347e016306.pdf
** static issue fixed and verified;
** dynamic issue remaining: bug 1720665. - 8cf6c672-3cad-4733-80c4-0f2e848b5ebf.pdf - partially fixed; loads and displays a first page, but does not work properly.
** static issue fixed and verified;
** dynamic issue remaining: bug 1720665. - sumatrapdf-1546-0-GOOD.pdf
** static issue fixed and verified;
** dynamic issue remaining: bug 1720667. - PDFIUM-292-0.pdf - NOT fixed; still does not load!
** static issue fixed and verified;
** dynamic issue remaining: bug 1720667.
Closing this report as verified.
Comment 18•3 years ago
|
||
Fixed in beta by the uplift in bug 1720361.
Updated•3 years ago
|
Description
•