Closed
Bug 1720846
Opened 3 years ago
Closed 3 years ago
Make the profiler buildable outside of `unified-build` environment
Categories
(Core :: Gecko Profiler, task, P2)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
92 Branch
Tracking | Status | |
---|---|---|
firefox92 | --- | fixed |
People
(Reporter: florian, Assigned: mozbugz)
References
Details
Attachments
(2 files)
tools/profiler and mozglue/baseprofiler should pass when running ./mach static-analysis check-syntax
on them, and then we can add these folders to the list at https://searchfox.org/mozilla-central/source/build/non-unified-compat
Currently there are errors in tools/profiler/tests/gtest/LulTestInfrastructure.cpp, tools/profiler/core/platform.cpp (incomplete JS::RecordAllocationInfo
type), mozglue/baseprofiler/core/ProfilerBacktrace.cpp and mozglue/baseprofiler/core/ProfilerBuffer.cpp.
Assignee | ||
Updated•3 years ago
|
Severity: -- → N/A
Priority: -- → P2
Assignee | ||
Comment 1•3 years ago
|
||
I'm getting build failures because of added files while working on bug 1716959, so I will work on this one now.
Assignee: nobody → gsquelart
Blocks: 1716959
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
Depends on D120301
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46ecc01a4a63
Fix non-unified build by adding missing #includes - r=florian
https://hg.mozilla.org/integration/autoland/rev/ee08d481f68e
Add mozglue/baseprofiler and tools/profiler to non-unified-compat - r=florian
Comment 5•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/46ecc01a4a63
https://hg.mozilla.org/mozilla-central/rev/ee08d481f68e
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•