Closed Bug 1626530 (non-unified) Opened 5 years ago Closed 1 year ago

[META] Build files in the non-unified build environment

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: andi, Unassigned)

References

(Depends on 1 open bug)

Details

(Keywords: meta)

In order to have compile_commands.json outside of the unified environment we must make sure that all files are syntax valid outside of the unified environment.

Flags: needinfo?(botond)
Depends on: 1626532
Depends on: 1626555
Depends on: 1626584
Depends on: 1626640
Depends on: 1626659
Flags: needinfo?(botond)
Depends on: 1627131
Depends on: 1627389
Depends on: 1627390
Depends on: 1627391
Depends on: 1627392
Depends on: 1627393
Alias: non-unified
Depends on: 1627480
Depends on: 1627482
No longer depends on: 1627480
No longer depends on: 1626659

I am curious: how do we verify that?

Depends on: 1627918

(In reply to Simon Giesecke [:sg] [he/him] from comment #1)

I am curious: how do we verify that?

Andi added a mach static-analysis check-syntax <path-to-directory> command that I've been using. It's pretty quick to run, doesn't need to do a full build.

Depends on: 1628433
Depends on: 1629732
Depends on: 1632779
Depends on: 1633014
Depends on: 1634131
Depends on: 1634154
Depends on: 1634217
Depends on: 1634370
Depends on: 1634474
Depends on: 1635129
Depends on: 1635132
Depends on: 1635364
Depends on: 1671380
Depends on: 1671599
Depends on: 1671641
Depends on: 1676915
Depends on: 1683532
Depends on: 1683534
Depends on: 1683540
Depends on: 1683551
Depends on: 1683553
Depends on: 1683557
Depends on: 1683561
Depends on: 1683613
Depends on: 1685760
Depends on: 1688292
Depends on: 1694161
Depends on: 1694187
Depends on: 1720846
Depends on: 1732481
Depends on: 1732840
Depends on: 1732844
Depends on: 1733038
Depends on: 1733308
Depends on: 1733545
Depends on: 1733547
Depends on: 598468
Depends on: 1326580
Depends on: 1750927
Depends on: 1757575
Depends on: 1757576
Depends on: 1757577
Depends on: 1767881
Depends on: 1770845
Depends on: 1789133
Severity: normal → S3
Depends on: 1817308
Depends on: 1817309
Depends on: 1817310
Depends on: 1817311
Depends on: 1817312
Depends on: 1817313
Depends on: 1817314
Depends on: 1817315
Depends on: 1817316
Depends on: 1817317
Depends on: 1817318
Depends on: 1817714
Depends on: 1817715
Depends on: 1817716
Depends on: 1817717
Depends on: 1817718
Depends on: 1817719
Depends on: 1817720
Depends on: 1817721
Depends on: 1817722
Depends on: 1818438
Depends on: 1818439
Depends on: 1818440
Depends on: 1818441
Depends on: 1818442
Depends on: 1818443
Depends on: 1818444
Depends on: 1818445
Depends on: 1818446
Depends on: 1818871
Depends on: 1819815
Depends on: 1819816
Depends on: 1819817
Depends on: 1819818
Depends on: 1819819
Depends on: 1819820
Depends on: 1819821
Depends on: 1819822
Depends on: 1820572
Depends on: 1820573
Depends on: 1820575
Depends on: 1820576
Depends on: 1820577
Depends on: 1820578
Depends on: 1820579
Depends on: 1820580
Depends on: 1823339
Depends on: 1823340
Depends on: 1823341
Depends on: 1823342
Depends on: 1823343
Depends on: 1823344
Depends on: 1823345
Depends on: 1823346
Depends on: 1823347
Depends on: 1823348
Depends on: 1824068
Depends on: 1824069
Depends on: 1824070
Depends on: 1824071
Depends on: 1824508
Depends on: 1824509
Depends on: 1824510
Depends on: 1824511
Depends on: 1824512
Depends on: 1824513
Depends on: 1824514
Depends on: 1824515
Depends on: 1824516
Depends on: 1824517
Depends on: 1824518
Depends on: 1824519
Depends on: 1824557
Depends on: 1825324
Depends on: 1825325
Depends on: 1825327
Depends on: 1825328
Depends on: 1825329
Depends on: 1825330
Depends on: 1825331
Depends on: 1825332
Depends on: 1825333
Depends on: 1825335
Depends on: 1825336
Depends on: 1826045
Depends on: 1826049
Depends on: 1826067
Depends on: 1826073
Depends on: 1826074
Depends on: 1826075
Depends on: 1826076
Depends on: 1826077
Depends on: 1826752
Depends on: 1826753
Depends on: 1826754
Depends on: 1826756
Depends on: 1826757
Depends on: 1826758
Depends on: 1826759
Depends on: 1826760
Depends on: 1826761
Depends on: 1827351
Depends on: 1827556
Depends on: 1828378
Depends on: 1828379
Depends on: 1828380
Depends on: 1828381
Depends on: 1828382
Depends on: 1828383
Depends on: 1828384
Depends on: 1828385
Depends on: 1828386
Depends on: 1828387
Depends on: 1828808
Depends on: 1830038
Depends on: 1830039

Do you want to do the honors and close this?

Flags: needinfo?(bpostelnicu)

It is time to be able to build in the non unified environment :)

Status: NEW → RESOLVED
Closed: 1 year ago
Flags: needinfo?(bpostelnicu)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.