Handle fallout from bug 1721627 - crash on requests to non-existing chrome: and resource: files on infra
Categories
(Thunderbird :: Upstream Synchronization, task)
Tracking
(thunderbird_esr78 unaffected, thunderbird91 unaffected)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | unaffected |
thunderbird91 | --- | unaffected |
People
(Reporter: darktrojan, Assigned: darktrojan)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
M-C landed a change which crashes the tests if we attempt to load a URL that doesn't exist. Of course that's something we do.
Assignee | ||
Comment 1•3 years ago
|
||
I'm going to push a change to un-bust the tests, then post a patch or two here to clean up the mess.
Assignee | ||
Comment 3•3 years ago
|
||
This code ultimately loads resource:///modules/AttributionCode.jsm which only exists in Firefox. It's now causing test crashes in Thunderbird due to bug 1721627, or it was, but I've temporarily hacked them into working.
Assignee | ||
Updated•3 years ago
|
Comment 4•3 years ago
|
||
The AttributionCode thing also hits android, and so I added an exception for it, but this patch seems like a plausible way of addressing it (though per the discussion in bug 1722082 I think there's some confusion about what bits of telemetry run where that may be good to resolve at a higher level - I'm not sure yet...)
Assignee | ||
Comment 5•3 years ago
|
||
Ah, I didn't know bug 1722082 was a thing. I found that loading AttributionCode was conditionally turned off elsewhere in the same file, so I've done the same thing here. Hopefully that doesn't make a mess of what you're working on.
Comment 7•3 years ago
|
||
bugherder |
Comment 8•3 years ago
|
||
(In reply to Geoff Lankow (:darktrojan) from comment #5)
Ah, I didn't know bug 1722082 was a thing. I found that loading AttributionCode was conditionally turned off elsewhere in the same file, so I've done the same thing here. Hopefully that doesn't make a mess of what you're working on.
Nope, this is great, thank you!
Assignee | ||
Updated•3 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/799588135781
Stop shipping AttributionCode.jsm. rs=me
Updated•3 years ago
|
Description
•