Closed Bug 1723628 Opened 3 years ago Closed 3 years ago

Handle fallout from bug 1721627 - crash on requests to non-existing chrome: and resource: files on infra

Categories

(Thunderbird :: Upstream Synchronization, task)

Tracking

(thunderbird_esr78 unaffected, thunderbird91 unaffected)

RESOLVED FIXED
92 Branch
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird91 --- unaffected

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

M-C landed a change which crashes the tests if we attempt to load a URL that doesn't exist. Of course that's something we do.

Depends on: 1721627

I'm going to push a change to un-bust the tests, then post a patch or two here to clean up the mess.

Keywords: leave-open
Target Milestone: --- → 92 Branch
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/03539b669fb8 Fix crash on requests to non-existing chrome: and resource: files on infra (bug 1721627). rs=bustage-fix

This code ultimately loads resource:///modules/AttributionCode.jsm which only exists in Firefox. It's now causing test crashes in Thunderbird due to bug 1721627, or it was, but I've temporarily hacked them into working.

Depends on: 1723642

The AttributionCode thing also hits android, and so I added an exception for it, but this patch seems like a plausible way of addressing it (though per the discussion in bug 1722082 I think there's some confusion about what bits of telemetry run where that may be good to resolve at a higher level - I'm not sure yet...)

Ah, I didn't know bug 1722082 was a thing. I found that loading AttributionCode was conditionally turned off elsewhere in the same file, so I've done the same thing here. Hopefully that doesn't make a mess of what you're working on.

Pushed by geoff@darktrojan.net: https://hg.mozilla.org/integration/autoland/rev/a349aee25be1 Stop loading AttributionCode.jsm outside of Firefox. r=chutten

(In reply to Geoff Lankow (:darktrojan) from comment #5)

Ah, I didn't know bug 1722082 was a thing. I found that loading AttributionCode was conditionally turned off elsewhere in the same file, so I've done the same thing here. Hopefully that doesn't make a mess of what you're working on.

Nope, this is great, thank you!

Keywords: leave-open

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/799588135781
Stop shipping AttributionCode.jsm. rs=me

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Depends on: 1733437
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: