Closed Bug 1721627 Opened 3 years ago Closed 3 years ago

Add code to chrome/jar channels that crashes in debug builds if trying to read non-existent files from omni.ja and similar packages

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1721627 - crash on requests to non-existing chrome: and resource: files on infra, r?#necko-reviewers
(deleted), text/x-phabricator-request
Details

bug 1721584 involves some icons that went AWOL after some refactoring . It would have been nice if the regressing bug 1708502, which stopped shipping those icons, would have turned the tree orange.

Depends on: 1721910
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #9232524 - Attachment description: WIP: Bug 1721627 - check for requests to non-existing chrome: and resource: files on infra → Bug 1721627 - crash on requests to non-existing chrome: and resource: files on infra, r?#necko-reviewers
Depends on: 1722076
Depends on: 1722078
Depends on: 1722082
Attachment #9232524 - Attachment description: Bug 1721627 - crash on requests to non-existing chrome: and resource: files on infra, r?#necko-reviewers → WIP: Bug 1721627 - crash on requests to non-existing chrome: and resource: files on infra, r?#necko-reviewers
Depends on: 1722485
Attachment #9232524 - Attachment description: WIP: Bug 1721627 - crash on requests to non-existing chrome: and resource: files on infra, r?#necko-reviewers → Bug 1721627 - crash on requests to non-existing chrome: and resource: files on infra, r?#necko-reviewers
Depends on: 1723525
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a670f5679e0b crash on requests to non-existing chrome: and resource: files on infra, r=necko-reviewers,valentin
Attachment #9234307 - Attachment description: Bug 1721627 - follow-up: don't crash on android due to AttributionCode.jsm, see bug 1722082, rs=bustage → Bug 1721627 - follow-up: don't crash on android due to AttributionCode.jsm or reftest hits, see bug 1722082, rs=bustage
Pushed by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bc5e08d27347 follow-up: don't crash on android due to AttributionCode.jsm or reftest hits, see bug 1722082, rs=bustage CLOSED TREE

Note that the use of xpc::IsInAutomation means that the check doesn't cover xpcshell tests (bug 1598804).

(In reply to Dorel Luca [:dluca] from comment #6)

Backed out 2 changesets (bug 1721627) for Talos failures.

lolsigh, tart uses dead favicons...

Depends on: 1723729
Attachment #9234307 - Attachment is obsolete: true
Flags: needinfo?(gijskruitbosch+bugs)
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5cded8230dac crash on requests to non-existing chrome: and resource: files on infra, r=necko-reviewers,valentin

https://hg.mozilla.org/mozilla-central/rev/5cded8230dac

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox92: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Blocks: 1724718
Depends on: 1728226
Regressions: 1734525
Regressions: 1734526
No longer regressions: 1734525
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1734525
No longer regressions: 1748506
No longer depends on: 1728226
Regressions: 1728226
Blocks: 1722082
No longer depends on: 1722082
No longer regressions: 1734526
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: