Closed
Bug 1723958
Opened 3 years ago
Closed 3 years ago
DevTools broken after using iframe picker with bfcache navigation
Categories
(DevTools :: Framework, defect, P3)
DevTools
Framework
Tracking
(firefox93 fixed)
RESOLVED
FIXED
93 Branch
Tracking | Status | |
---|---|---|
firefox93 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
- enable fission
- open http://odvarko.com/tests/fission/case1/index.html
- open devtools
- navigate to https://www.wikipedia.org/
- go back
- in iframe dropdown select http://odvarko.com/tests/fission/case1/odvarko.com.html
- go forward
- go back
Markup view will be blank, console doesn't work, etc... The following error is visible in the logs:
JavaScript error: resource://devtools/server/connectors/js-window-actor/DevToolsFrameChild.jsm, line 247: Error: DevToolsFrameChild _createTargetActor was called more than once for the same Watcher (Actor ID: "server0.conn1.watcher2")
Updated•3 years ago
|
Summary: Iframe picker does not work after bfcache navigation → DevTools broken after using iframe picker with bfcache navigation
Comment 1•3 years ago
|
||
I can reproduce on my machine (Win10), my prefs are:
fission.autostart
=> truedevtools.target-switching.server.enabled
=> truefission.bfcacheInParent
=> true
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
I created a test that demonstrates the issue: https://phabricator.services.mozilla.com/D121727
It runs fine without fission, fails with fission + bfcache, and passes with fission enabled but bfcache disabled.
So we can say it is related to bfcache
Updated•3 years ago
|
Assignee: nobody → nchevobbe
Attachment #9234674 -
Attachment description: WIP: Bug 1723958 - [devtools] Add test for iframe picker + inspector + bfcache → Bug 1723958 - [devtools] Use targetActor.originalWindow instead of window in bfcache navigation. r=jdescottes.
Status: NEW → ASSIGNED
Updated•3 years ago
|
Severity: -- → S3
Priority: -- → P3
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3a3f6075172e [devtools] Use targetActor.originalWindow instead of window in bfcache navigation. r=jdescottes.
Comment 5•3 years ago
|
||
Backed out changeset 3a3f6075172e (Bug 1723958) for causing xpcshell failures on test_addon_debugging_connect.js.
Backout link
Push with failures
Failure Log
Flags: needinfo?(nchevobbe)
Assignee | ||
Comment 6•3 years ago
|
||
oops, pushed a fix: https://treeherder.mozilla.org/jobs?repo=try&revision=cba1e3ecc9db2d6c092d8d72e26d0303a84c56c1
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bba88f3be2ff [devtools] Use targetActor.originalWindow instead of window in bfcache navigation. r=jdescottes.
Comment 8•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox93:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•