Closed Bug 1608054 Opened 5 years ago Closed 3 years ago

Make the Iframe picker Fission compatible

Categories

(DevTools :: Framework, defect, P2)

defect

Tracking

(Fission Milestone:Future)

RESOLVED FIXED
Fission Milestone Future

People

(Reporter: Honza, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-future, dt-perf-stability-mvp )

The IFrame Picker button available in Toolbox Toolbar - used to select an iframe as the currently targeted document should continue working in Fission world.

Honza

Fission Milestone: --- → M6
Priority: P3 → P2
Whiteboard: dt-fission-m2-mvp → dt-fission-m2-mvp

This would only be doable once we fully support target switching, which itself would only be possible once we support early resources correctly.
So this will be actionnable only once M2 is completed.

Whiteboard: dt-fission-m2-mvp → dt-fission-m2-reserve

dt-fission-m2-reserve bugs do not need to block Fission Nightly (M6). For now, let's track them for Fission riding the trains to Beta (M7) so we revisit these bugs before we ship Fission.

Fission Milestone: M6 → M7

Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.

Fission Milestone: M7 → MVP
Whiteboard: dt-fission-m2-reserve → dt-fission-m3-mvp
Whiteboard: dt-fission-m3-mvp → dt-fission-m3-reserve

I'm wondering if this depends on bug 1602748, where we would spawn one target per WindowGlobal.

Here for the iframe picker, we need to spawn targets for in-process iframe. Today, they are being debugged via the top level target.
But it would be nice if all iframes were debugged the same way, via a dedicated target.
But doing this means that all features currently broken for remote iframe, will suddently also be broken for in-process iframes.

Otherwise, it means that the iframe picker has to handle both codepath, which may be very hairy:

  • in-process iframes, with existing code, listening to frameUpdate event on top level target, and using BrowsingContextTargetActor.switchToFrame, in order to do a server side "document switching",
  • remote iframes, with new code to write, listening to target available, and doing a target switching on the client side, via TargetList.switchToTarget.

Depends on 1685500 in order to emit targets for in-process iframes.

Depends on: 1685500

Moving "dt-fission-m3-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.

Fission Milestone: MVP → Future
Whiteboard: dt-fission-m3-reserve → dt-fission-future
Depends on: 1723958
Depends on: 1718325
Whiteboard: dt-fission-future → dt-fission-future, dt-perf-stability-mvp

(this doesn't really block the evaluation context selector work)

Depends on: 1730148
No longer depends on: 1685500

With EFT enabled, the iframe picker is definitely Fission compatible

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
No longer depends on: 1718325
You need to log in before you can comment on or make changes to this bug.