Remove the non-e10s xpcshell test configurations for extension tests
Categories
(WebExtensions :: Android, task, P2)
Tracking
(Not tracked)
People
(Reporter: robwu, Unassigned)
References
Details
(Whiteboard: [addons-jira])
It is not possible to disable e10s, see bug 1724089 for details.
So we should remove the browser.tabs.remote.autostart
=false setter at https://searchfox.org/mozilla-central/rev/4b49a0dc50104e03ecadd1fd1902b27be6b9c0c8/toolkit/components/extensions/test/xpcshell/head.js#46 (because it does not work!!!), and reduce the number of distinct xpcshell
test manifests.
The current list of tests is described at https://searchfox.org/mozilla-central/rev/4b49a0dc50104e03ecadd1fd1902b27be6b9c0c8/toolkit/components/extensions/test/xpcshell/xpcshell.ini#26-36:
xpcshell-common.ini
- included byxpcshell.ini
andxpcshell-remote.ini
xpcshell-common-e10s.ini
- included byxpcshell-remote.ini
andxpcshell-e10s.ini
xpcshell-remote.ini
--- e10s + OOP extensions = primary target (all desktop)xpcshell-content.ini
-- included byxpcshell-remote.ini
,xpcshell-e10s.ini
andxpcshell.ini
xpcshell-e10s.ini
- e10s + in-process extensions = GeckoView (until bug 1535365 is fixed) however it is currently skipped on Androidxpcshell.ini
- "non-e10s" (e10s in practice) + in-process extensions (former target for Fennec) = GeckoView in practice
We should cut the number of test manifests to three:
xpcshell-common.ini
- unchanged- merge withxpcshell-common-e10s.ini
xpcshell-remote.ini
xpcshell-remote.ini
- unchanged- merge withxpcshell-content.ini
xpcshell-common.ini
- delete (there are no other tests other than the inclusions)xpcshell-e10s.ini
xpcshell.ini
- change comment/tags to match reality: e10s + in-process extensions (GeckoView, until bug 1535365)
Besides merging the test manifests, we should also consolidate head.js (as mentioned before), head_e10s.js
and head_remote.js
, and check whether the skip-if = os == "android"
are still needed (bug 1680132).
Comment 1•3 years ago
|
||
Hey Geoff, you might be interested in this because of Thunderbird, not sure how far along with e10s you are there.
Updated•3 years ago
|
Comment 3•3 years ago
|
||
Actually, I think this would result in us running some tests we didn't previously run. I'll check that they are passing when I have a build again.
Comment 4•3 years ago
|
||
Everything seems fine. We were skipping xpcshell-e10s.ini
but I changed that and didn't have any failures. (We still need to skip xpcshell-legacy-ep.ini
but you didn't mention that so I assume nothing is changing there.) Thanks for checking.
Updated•3 years ago
|
Reporter | ||
Updated•2 years ago
|
Updated•2 years ago
|
Reporter | ||
Updated•1 year ago
|
Description
•