Closed Bug 1724185 Opened 3 years ago Closed 3 years ago

Values containing an equal character in search filter for LDAP address book are broken

Categories

(Thunderbird :: Address Book, defect)

Thunderbird 91
defect

Tracking

(thunderbird_esr78 unaffected, thunderbird_esr91 fixed, thunderbird91 wontfix, thunderbird92 fixed)

RESOLVED FIXED
93 Branch
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird_esr91 --- fixed
thunderbird91 --- wontfix
thunderbird92 --- fixed

People

(Reporter: plucth, Assigned: rnons)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

I have an address book with this search filter in the form (memberof=cn=Group,dc=domain,dc=local) that I use to filter a subset of my LDAP directory

Actual results:

There is no result at all since the value is cut at the first equal character and become (memberof=cn)

Expected results:

The filter value should be included entirely and the search should return results.

Blocks: tb91found
Assignee: nobody → remotenonsense
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Regressed by: ldap-js

Fix the case of filter string like (memberof=cn=Group,dc=domain,dc=local), find the position of the first equal symbol and split from there.

Status: NEW → ASSIGNED
Target Milestone: --- → 92 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/e60063c4eb75
Fix parsing filter string containing multiple equals in LDAPMessage.jsm. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: 92 Branch → 93 Branch

Comment on attachment 9234999 [details]
Bug 1724185 - Fix parsing filter string containing multiple equals in LDAPMessage.jsm. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): bug 1696625
User impact if declined: If filter string contains multiple equal symbols, search doesn't work
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9234999 - Flags: approval-comm-esr91?
Attachment #9234999 - Flags: approval-comm-beta?

Comment on attachment 9234999 [details]
Bug 1724185 - Fix parsing filter string containing multiple equals in LDAPMessage.jsm. r=darktrojan

[Triage Comment]
Approved for 92.0b1

Attachment #9234999 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9234999 [details]
Bug 1724185 - Fix parsing filter string containing multiple equals in LDAPMessage.jsm. r=darktrojan

[Triage Comment]
Approved for esr91

Attachment #9234999 - Flags: approval-comm-esr91? → approval-comm-esr91+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: