Garbled characters occur when the description of the SMTP server is in Japanese.
Categories
(Thunderbird :: Account Manager, defect)
Tracking
(thunderbird_esr78 unaffected, thunderbird_esr91+ fixed, thunderbird88 wontfix, thunderbird89 wontfix, thunderbird90 wontfix, thunderbird91 wontfix, thunderbird92+ fixed)
People
(Reporter: alice0775, Assigned: rnons)
References
(Regression)
Details
(Keywords: nightly-community, regression)
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr91+
|
Details |
screenshot
Steps To Reproduce:
- Tool > Account Settings
- Outgoing Server(SMTP) Settings > Add
- Input
アイウin Description field - Input
smtp.gmail.comin Server Name field - OK
--- observe BUG, Descriptions are garbled.
Actual Results:
Descriptions are garbled.
See attached screenshot.
Expected Results:
Descriptions should not be garbled.
Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=a13da366d8460497a948184ef669cf99f560c4d0&tochange=d717ba817b41715f11400fd4e5d24cb709508ebb
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1add9a1bbfacd4ff1bee961fa8886b8cd0566d23&tochange=97a677952b4b25afd4548562dd06e604c50b373e
|
Reporter | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Comment 1•3 years ago
|
||
Not sure about this as I haven't worked on this section.
Maybe Ping knows something as he worked on implementing the nsISmtpService in JS.
|
||
Comment 2•3 years ago
|
||
The description string is stored in the pref: mail.smtpserver.smtp<ID>.description
With mailnews.smtp.jsmodule = FALSE the encoding is UTF-8.
With mailnews.smtp.jsmodule = TRUE the encoding is Windows-1252.
|
Assignee | |
Comment 3•3 years ago
|
||
getCharPref/setCharPref operates with ACString, but description/hostname in nsISmtpServer are AUTF8String. Unlike C++ XPCOM, XPConnect doesn't help us convert automatically in this case. This patch introduces StringUtils.jsm to reuse the convertion code.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/ba1d334eca8f
Fix getter/setter of description/hostname in SmtpServer.jsm. r=mkmelin
|
|
Assignee | |
Comment 5•3 years ago
|
||
Comment on attachment 9236557 [details]
Bug 1726018 - Fix getter/setter of description/hostname in SmtpServer.jsm. r=mkmelin
[Approval Request Comment]
Regression caused by (bug #): bug 1661694
User impact if declined: Non-ascii description for smtp server doesn't work
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low
|
|
||
Comment 6•3 years ago
|
||
Comment on attachment 9236557 [details]
Bug 1726018 - Fix getter/setter of description/hostname in SmtpServer.jsm. r=mkmelin
[Triage Comment]
Approved for beta
|
|
||
Comment 7•3 years ago
|
||
We're building 91.0.2 today, but this hasn't yet been on beta. So this will be eligible for 91.0.3 which will probably happen next week.
|
|
||
Updated•3 years ago
|
|
||
Comment 8•3 years ago
|
||
| bugherder uplift | ||
Thunderbird 92.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/b11e5ec6e4f8
|
|
||
Comment 9•3 years ago
|
||
Comment on attachment 9236557 [details]
Bug 1726018 - Fix getter/setter of description/hostname in SmtpServer.jsm. r=mkmelin
[Triage Comment]
Approved for esr91
|
|
||
Comment 10•3 years ago
|
||
| bugherder uplift | ||
Thunderbird 91.0.3:
https://hg.mozilla.org/releases/comm-esr91/rev/caab4643bba8
Description
•