User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

When using the "Customize From Address" option and switching the from domain part, Thunderbird still uses the original account domain for the Message-Id calculation instead of the actual From address domain. This publicly associates addresses from different domains and uses the users' login info for message id instead of the actual email (domain) in use.

Is this a regression from a previous version?

I don't believe so, though I admit I haven't dug into it particularly deeply.

https://searchfox.org/comm-central/rev/c4f87ae30bf85e5a2654b2d875b387d100aab33d/mailnews/compose/src/SmtpService.jsm#111-114
I suppose we should move the message id generation into js around there.

We could move msgGenerateMessageId into https://searchfox.org/comm-central/source/mailnews/compose/src/MimeMessageUtils.jsm
Or rather add a copy. Once nsIMsgMdnGenerator.idl is rewritten in js the cpp msgGenerateMessageId version can go.

I want to take up on this issue. If no one else is working on it.

Great, go for it! The bug will get assigned automatically when you submit a patch.

Riya, any update?

This issue hasn't seen some activity, so I would like to attempt it if that's okay. Magnus, can I add you as reviewer when I submit a patch?

Absolutely, please see https://developer.thunderbird.net/thunderbird-development/fixing-a-bug#submitting-a-patch
Let me know if you have any questions.

Gentle ping to Magnus since the patch was uploaded to phabricator as WIP, so probably no notification was triggered by Phab.

Left some comments on phabricator. Luuk, please check it.

Luuk, are you up for finishing the patch?

Assigning this to Brendan to see if he can bring this home

Loosely inspired by the patch from @lkkmpn.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/6244570ecfa4
Generate the Message-ID header using the From address when sending a message from the composer. r=leftmostcat

Request uplift to beta when you are ready, which is a necessary step before it can be brought to version 115.
Or you can let it ride on 117 until 117 becomes beta.

Comment on attachment 9341530 [details]
Bug 1727181 - Generate the Message-ID header using the From address when sending a message from the composer. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: Wrong usage of the message ID during compose if the user manually enters a custom "from" address.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): Fairly low risk because the changes are self contained on an area that is well covered by tests. Requesting uplift because some interfaces are changing and it would make it difficult to uplift further fixes.

Comment on attachment 9341530 [details]
Bug 1727181 - Generate the Message-ID header using the From address when sending a message from the composer. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Thunderbird 116.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/71b19af1b9d6

Comment on attachment 9341530 [details]
Bug 1727181 - Generate the Message-ID header using the From address when sending a message from the composer. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Thunderbird 115.1.0:
https://hg.mozilla.org/releases/comm-esr115/rev/b7249e50ac7b